-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SCOORD to a Measurement in SR (TID 320) #306
Comments
Hi @Fedalto, thanks for the question This is not supported right now but I would certainly consider a PR to add it. However, have you considered whether using already supported behaviour of PlanarROIMeasurementsAndQualitativeEvaluations (or VolumetricROIMeasurementsAndQualitativeEvaluations if you want SCOORD3D coordinates) could be used for your use case? In these cases you can specify the So this is sort of the the "other way up" to what you propose. You specify an image region and then, within it, measurements that relate to that region. Would that work for your use case? I would like to better understand in what scenarios TID 320 would be prefereable. |
Hi @CPBridge. I'm using the ImageRegion as well. So, in the end, the SR structure would be like
|
This adds support for row 3 and 4 from TID 320. Resolves ImagingDataCommons#306
This adds support for row 3 and 4 from TID 320. Resolves ImagingDataCommons#306
This adds support for row 3 and 4 from TID 320. Resolves ImagingDataCommons#306
This adds support for row 3 and 4 from TID 320. Resolves ImagingDataCommons#306
Thanks for the PR I'll take a look at some point in the next few days! Your use case makes sense to me, just wanted to check that there wasn't a simpler way to solve your problem :) |
Resolved by #307, this will be included in the |
Hi, is it possible to add spatial coordinates to a Measurement in SR?
I'm looking at TID 320 Image or Spatial Coordinates, specifically row 3 and 4.
If it's not currently possible, I could work on a PR to add it.
But I could use some pointers on how to best implement it.
As I understand, the
referenced_images
parameter insr.Measurement
implements the first row of TID 320 (inferred from image).What's the best solution to add the other options? Should a new parameter in
sr.Measurement
be added for each one? Or thereferenced_images
type could be changed toOptional[Sequence[SourceImageForMeasurement | SourceScoordForMeasurement]]
?The text was updated successfully, but these errors were encountered: