Compute plane positions more efficiently for TILED_FULL dimension organization #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Dimension Organization is
TILED_FULL, the position of frames in a multi-frame image needs to be computed. The current implementation of thecompute_plane_position_slide_per_frame()function performs this computation in an inefficient manner by callingcompute_plane_position_tiled_full()for each frame, which internally constructs aPixelToReferenceTransformerobject for every invocation. This PR improves the performance of the computation by constructing aPixelToReferenceTransformerobject once and then re-using the object repeatedly. I tested this on a larger VL Whole Slide Microscopy Image instance and was able to speed up the computation from 2.38 seconds to 1.65 seconds.