Make pylibjpeg-libjpeg optional #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 10, 2022 14:28
|
I also expanded the CI tests to run the test suite with and without pylibjpeg-libjpeg. With it, the full tests are run. Without it, tests that depend on it are skipped. |
hackermd
requested changes
Oct 10, 2022
Co-authored-by: Markus D. Herrmann <hackermd@users.noreply.github.com>
Co-authored-by: Markus D. Herrmann <hackermd@users.noreply.github.com>
hackermd
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highdicom is licensed under the permissive MIT license to allow users to use in their own applications, regardless of licence.
Unfortunately, it currently depends on
pylibjpeg-libjpeg, which is GPL v3 licensed. This effectively means that many users cannot use highdicom. Luckily highdicom only usespylibjpeg-libjpegindirectly through pydicom and only in a few specific cases (decoding pixel data with a few specific transfer syntaxes).This PR moves
pylibjpeg-libjpegto an optional dependency, that users may install withpip install highdicom[libjpeg], and adds documentation to this effect.It also alters the tests so that the relevant tests are automatically skipped if
pylibjpeg-libjpegis not installed. This necessitated a (long overdue) restructuring of the segmentation tests to split for loops within a single test to parameterized tests (using fixtures).