Optionally skip deepcopy in from_dataset
methods
#207
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaked all
from_dataset
methods to accept a new booleancopy
parameter (defaultTrue
) in order to skip the copy operation to improve performance. IfFalse
, the dataset parameter is altered in place. This is now used in thesegread
method, and dramatically improves the performance there.@pieper this should cut around 25% off your large seg benchmark time based on my testing