Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement srread function #215

Merged
merged 8 commits into from
Apr 1, 2023
Merged

Implement srread function #215

merged 8 commits into from
Apr 1, 2023

Conversation

CPBridge
Copy link
Collaborator

@CPBridge CPBridge commented Feb 8, 2023

Adding a convenience function highdicom.sr.srread, equivalent to highdicom.seg.segread, capable of reading in any SR document supported by highdicom.

@CPBridge CPBridge added the enhancement New feature or request label Feb 8, 2023
src/highdicom/sr/sop.py Outdated Show resolved Hide resolved
src/highdicom/sr/sop.py Outdated Show resolved Hide resolved
src/highdicom/sr/sop.py Outdated Show resolved Hide resolved
CPBridge and others added 2 commits February 19, 2023 12:40
Co-authored-by: Markus D. Herrmann <hackermd@users.noreply.github.com>
Copy link
Collaborator

@hackermd hackermd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few suggestions regarding variable names to improve clarity.

src/highdicom/sr/sop.py Outdated Show resolved Hide resolved
src/highdicom/sr/sop.py Outdated Show resolved Hide resolved
src/highdicom/sr/sop.py Outdated Show resolved Hide resolved
tests/test_sr.py Outdated Show resolved Hide resolved
tests/test_sr.py Outdated Show resolved Hide resolved
CPBridge and others added 5 commits April 1, 2023 16:20
Co-authored-by: Markus D. Herrmann <hackermd@users.noreply.github.com>
Co-authored-by: Markus D. Herrmann <hackermd@users.noreply.github.com>
Co-authored-by: Markus D. Herrmann <hackermd@users.noreply.github.com>
Co-authored-by: Markus D. Herrmann <hackermd@users.noreply.github.com>
Change variable name

Co-authored-by: Markus D. Herrmann <hackermd@users.noreply.github.com>
@CPBridge CPBridge requested a review from hackermd April 1, 2023 16:31
@CPBridge CPBridge merged commit bba72ce into master Apr 1, 2023
@CPBridge CPBridge deleted the feature/srread2 branch April 1, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants