Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support images with different FrameOfReferenceUIDs #118

Merged
merged 2 commits into from
Jul 1, 2022
Merged

Support images with different FrameOfReferenceUIDs #118

merged 2 commits into from
Jul 1, 2022

Conversation

hackermd
Copy link
Collaborator

Fixes #116

@hackermd hackermd added bug Something isn't working idc:priority Priority for the NCI's Imaging Data Commons labels Jun 30, 2022
@hackermd hackermd requested review from dclunie and Punzo June 30, 2022 20:40
@hackermd hackermd self-assigned this Jun 30, 2022
@github-actions
Copy link

github-actions bot commented Jun 30, 2022 •
edited
Loading

Visit the preview URL for this PR (updated for commit b075c89):

https://idc-external-006--pr118-bugfix-label-image-f-htoex0q1.web.app

(expires Thu, 07 Jul 2022 21:23:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@dclunie
Copy link

dclunie commented Jun 30, 2022

C3N-01016 displays images and omits label (I am assuming it is from the reconversion with the label, and not an earlier conversion)

@fedorov
Copy link
Member

fedorov commented Jun 30, 2022

@dclunie that link points to a different instance of Slim that is not connected to the DICOM store where we keep the reconverted datasets.

Punzo
Punzo approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@Punzo Punzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hackermd
Copy link
Collaborator Author

hackermd commented Jul 1, 2022

@dclunie @fedorov the demo instance that is used to provide a preview does not contain a study that has VOLUME and LABEL images with different frame of references (as far as I know).

@hackermd hackermd merged commit 5e75eb9 into master Jul 1, 2022
@hackermd hackermd deleted the bugfix/label-image-frame-of-reference branch July 1, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Punzo Punzo Punzo approved these changes

@dclunie dclunie Awaiting requested review from dclunie

Assignees

@hackermd hackermd

Labels
bug Something isn't working idc:priority Priority for the NCI's Imaging Data Commons released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve handling of digital slides with images that have different frame of references
4 participants
@hackermd @dclunie @fedorov @Punzo