Fix warning "PHP Deprecated: mb_convert_encoding(): Handling HTML ent…

…ities via mbstring is deprecated"
Imangazaliev · Mar 5, 2023 · 50fa659 · 50fa659
1 parent cc8ec6e
commit 50fa659
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.travis.yml b/.travis.yml
@@ -20,6 +20,10 @@ jobs:
       dist: focal
       php: 8.1
 
+    - language: php
+      dist: jammy
+      php: 8.2
+
 before_script:
   - composer self-update
   - composer install

diff --git a/src/DiDom/Encoder.php b/src/DiDom/Encoder.php
@@ -14,7 +14,8 @@ class Encoder
      */
     public static function convertToHtmlEntities(string $string, string $encoding): string
     {
-        if (function_exists('mb_convert_encoding')) {
+        // handling HTML entities via mbstring is deprecated in PHP 8.2
+        if (function_exists('mb_convert_encoding') && PHP_VERSION_ID < 80200) {
             return mb_convert_encoding($string, 'HTML-ENTITIES', $encoding);
         }