-
Notifications
You must be signed in to change notification settings - Fork 36
update go and swap to graphicsmagic #108
base: master
Are you sure you want to change the base?
Conversation
👍 |
Hey @erulabs! If you switch to gm you no longer need the imagemagick policy: |
Hey @briankassouf - thanks haha :) Hope all is well! |
@@ -6,7 +6,7 @@ import ( | |||
"github.com/Imgur/mandible/imageprocessor/thumbType" | |||
) | |||
|
|||
const GM_COMMAND = "convert" | |||
const GM_COMMAND = "gm convert" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the exec command will like this space. You might need to change the runProcessorCommand
so that it adds convert
as the first item in the argument slice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the runProcessorCommand
function is used more generically for other types of commands then gm. Perhaps a new function that wraps runProcessorCommand
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrm - yeah - I think i'll just add "convert" as an arg to each of those commands. That way runProcessorCommand
stays generic and we can use other parts of gm
easily if we want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
gm convert
instead of imagemagick