-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blacklists to config #52
Conversation
Hey! I like your idea and I think it would provide value to the mod, so overall I want to add your contribution to the mod. |
Gotcha! I don't really see a legal problem here since the license just requires it to be displayed on derivatives or redistributions, and I didn't change the license. |
Yes, the problem is not necessarily linked to the license, but instead to the fact that you technically own the code you contributed, thus you retain copyright of part of the project. This should be reflected in some way in the files of the project, or it needs to be clear that contributors give up copyright to their contributions in some way. On another note, you technically can distribute your contribution under another license, since BSD does not enforce you to use BSD for derived works: https://softwareengineering.stackexchange.com/questions/185566/does-a-bsd-licensed-project-need-a-signed-statement-from-each-contributor Here is another explanation: https://haacked.com/archive/2006/01/26/WhoOwnstheCopyrightforAnOpenSourceProject.aspx/ I think an easy and fair way to do this, would be for me to introduce an contributors.md-file where you explicitly agree that your contributions are licensed with BSD, etc. Of course you would need to agree with that; I'll sort something out in the comming week(s). |
Sure; I'd be fine with the contributors.md file. |
Hello again! After a bit of thinking and tinkering I've arrived at a CONTRIBUTORS.md-file that should be acceptable. |
Added! |
Great! |
All good! |
Adds item and enchantment blacklists to config, such that items cannot be disenchanted or certain enchantments cannot be removed.