Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use terser version of class names for devices #403

Closed
alexdewar opened this issue Nov 13, 2023 · 0 comments · Fixed by #428
Closed

Use terser version of class names for devices #403

alexdewar opened this issue Nov 13, 2023 · 0 comments · Fixed by #428
Assignees

Comments

@alexdewar
Copy link
Collaborator

Currently, the class names for devices (e.g. in DeviceTypeInfo) include the full module name (e.g. finesse.hardware.plugins.whatever.MyDevice). This makes config files unnecessarily verbose and means that if we move files around (e.g. because the project's name changes: #352) the config files will break. While at least part of the module name is needed (we import plugin modules lazily as needed), we could at least drop the finesse.hardware.plugins prefix.

alexdewar added a commit that referenced this issue Nov 14, 2023
This makes config files less verbose and means if/when we change the
name of the main package, things won't break.

Closes #403.
alexdewar added a commit that referenced this issue Nov 21, 2023
This makes config files less verbose and means if/when we change the
name of the main package, things won't break.

Closes #403.
alexdewar added a commit that referenced this issue Apr 17, 2024
This makes config files less verbose and means if/when we change the
name of the main package, things won't break.

Closes #403.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant