-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy GitHub workflows #655
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #655 +/- ##
==========================================
+ Coverage 84.67% 84.80% +0.12%
==========================================
Files 69 69
Lines 3452 3448 -4
==========================================
+ Hits 2923 2924 +1
+ Misses 529 524 -5 ☔ View full report in Codecov by Sentry. |
0b31a54
to
825ff47
Compare
825ff47
to
6f99a24
Compare
72f7df3
to
e2a5eb6
Compare
e2a5eb6
to
b22d986
Compare
b22d986
to
8f551b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty cool! I didn't know about "composite" and I bet others don't know, either. I suggest you report this in Teams or in the next team meeting.
Co-authored-by: Diego Alonso Álvarez <6095790+dalonsoa@users.noreply.github.com>
Neither did I but it seems handy! I'll bring it up in the team meeting. |
As with many of our projects, FINESSE currently has one large workflow file which does several different things (running tests, building documentation, building release artifacts) and I thought it would be cleaner to try to separate this out a bit.
Specifically:
The docs workflow uses the new GitHub Actions method for deploying docs rather than the
gh-pages
branch, which brings a few advantages. I tested that the action actually works by deploying from this branch.