Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'PAUSED' to progress bar text when measurement script paused #657

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

dc2917
Copy link
Contributor

@dc2917 dc2917 commented Oct 21, 2024

Description

This PR contains an update to the measure script dialog window, such that when the script is paused, the progress bar text changes from xy% to PAUSED (xy%), and back to xy% when unpaused.

This is achieved by updating the format attribute of the associated QProgressBar, rather than explicitly changing the displayed text.

Fixes #285

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation (non-breaking change that adds or improves the documentation)
  • Optimisation (non-breaking, back-end change that speeds up the code)

Key checklist

  • Pre-commit hooks run successfully (pre-commit run -a)
  • All tests pass (pytest)
  • The documentation builds without warnings (mkdocs build -s)
  • Check the GUI still works (if relevant)
  • Check the code works with actual hardware (if relevant)
  • Check the pyinstaller-built executable works (if relevant)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests have been added or an issue has been opened to tackle that in the future.

@dc2917 dc2917 requested a review from alexdewar October 21, 2024 15:59
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.82%. Comparing base (6d86e1b) to head (b8d79cb).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #657      +/-   ##
==========================================
+ Coverage   84.67%   84.82%   +0.15%     
==========================================
  Files          69       69              
  Lines        3452     3454       +2     
==========================================
+ Hits         2923     2930       +7     
+ Misses        529      524       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@alexdewar alexdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Thanks 👍

@alexdewar alexdewar merged commit 9b5c78e into main Oct 22, 2024
9 checks passed
@alexdewar alexdewar deleted the add_pause_indicator branch October 22, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it clearer when measure scripts are paused
2 participants