-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for the sensors panel #696
Conversation
Hmm... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
==========================================
+ Coverage 85.31% 86.30% +0.98%
==========================================
Files 69 69
Lines 3549 3549
==========================================
+ Hits 3028 3063 +35
+ Misses 521 486 -35 ☔ View full report in Codecov by Sentry. |
Yeah, had this on the mirror angle PR as well, for the exact same thing. It's related to the In terms of running mypy, I have it running as a pre-commit hook but perhaps it's ignoring the tests/ directory. Pretty sure I ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Thanks for sorting this!
There's one line I think you can drop. but it's not esp important.
Description
This PR adds units tests for the functionality of the sensors panel on the GUI.
Fixes #106
Type of change
Key checklist
pre-commit run -a
)pytest
)mkdocs build -s
)pyinstaller
-built executable works (if relevant)Further checks