-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor polars handling and add external plotting tools #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and create example
…rty in rawdata objects
…mporting a generic file
This will integrate their info dicts into the dataframe
Prevents collection of columns if label argument happens to match a column name
kaleido and ipython removed as required dependencies. This is not a breaking change as the .show() method remains.
Remove requirement to specify all groups independently
tomjholland
added
backend
Related to the business logic of the tool
feature
Adding a new functionality, small or large
frontend
Related to the user interaction layer (GUI, UI or UX)
refactor
Refactoring existing code without significantly changing functionality
labels
Jan 2, 2025
This was referenced Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes across different files to improve the documentation and testing processes, as well as to update the examples with new plotting methods.
Features:
.plot()
method to allow quick plotting from all results objecthvplot()
method for quick dynamic plottingEnhancements:
.collect()
methodRefactor:
Documentation and Testing Updates:
CONTRIBUTING.md
: Added a note to follow the angular commit style and updated the test command to useuv run pytest
instead ofpytest
. [1] [2]docs/source/developer_guide/developer_installation.rst
: Simplified the virtual environment setup command to useuv sync --all-extras --all-groups
.Example Updates:
docs/source/examples/LEAN-differentiation.ipynb
: Replacedpyprobe.Plot
withmatplotlib.pyplot
for plotting and updated the plotting commands accordingly. Closes Address performance issues running Plot.show_image() #145 [1] [2] [3] [4] [5]docs/source/examples/analysing-GITT-data.ipynb
: Updated the plotting commands to usematplotlib.pyplot
instead ofpyprobe.Plot
. [1] [2] [3] [4] [5] [6]docs/source/examples/differentiating-voltage-data.ipynb
: Changed the plotting method frompyprobe.Plot
tomatplotlib.pyplot
and updated the plotting commands. [1] [2] [3] [4] [5] [6] [7]docs/source/examples/filtering-data.ipynb
: Replacedpyprobe.Plot
withmatplotlib.pyplot
for plotting and updated the plotting commands. [1] [2]Workflow Configuration:
.github/workflows/ci.yml
: Removed the installation step fornbmake
and updated the test command to useuv run pytest --nbmake
.