-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Kafka service to docker compose #103
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 43 43
=========================================
Hits 43 43 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not going to pretend that I understand any of the docker compose settings for the Kafka app, but it works and it will make the development way easier. Thanks for putting this together!!
Good. Me either. |
5baefeb
to
4e84ba8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. Just to be on the same page: process-manager-no-kafka.json
is no longer used, just there if the user wants to manually set up?
Description
After spending a couple of hours with @jamesturner246 getting the Pocket Kafka distribution to work, I decided to take another look at getting Kafka into Docker Compose. Rather than the official Apache image I tried one produced by Bitnami and it seems to just work... 🤷 at least for our purposes.
You can now just run
docker compose up
to get a development stack including Kafka messages. This should enablethose who work on non-linux platforms.Type of change
Key checklist
python -m pytest
)python -m sphinx -b html docs docs/build
)pre-commit run --all-files
)Further checks