Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade to python3.11 #65

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Downgrade to python3.11 #65

merged 2 commits into from
Sep 11, 2024

Conversation

cc-a
Copy link
Contributor

@cc-a cc-a commented Sep 11, 2024

Description

Downgrade from python 3.12 to 3.11. Unfortunately this is necessary for the Kafka work due to a bug with the Kafka client library in 3.12 - dpkp/kafka-python#2412. Whilst we could swap to the alternative python-kafka-ng package this is described as a workaround and the relationship between the 2 is not fully clear.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a pity.

It should be flagged in the next meeting - or at some point - as a potential barrier for the long term sustainability of the tool.

@@ -8,7 +8,7 @@ authors = [
]

[tool.poetry.dependencies]
python = "^3.12"
python = "^3.11"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be limited to "<3.12"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a tool where deployment will be in a controlled environment it's best to pin against a specific version so we don't have to worry about testing on different versions. That reminds me. Forgot to update the CI.

@cc-a
Copy link
Contributor Author

cc-a commented Sep 11, 2024

Going to merge this now. Be aware @dalonsoa @AdrianDAlessandro @jamesturner246 @TinyMarsh that poetry will complain and make you recreate your environment with python3.11 the next time you do something with dependencies after pulling in the changes. You can use poetry env use /path/to/python3.11 to do so. Sorry for the inconvenience.

@cc-a cc-a merged commit ee56e8c into main Sep 11, 2024
4 checks passed
@cc-a cc-a deleted the python-3.11 branch September 11, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants