Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New publish workflow #81

Merged
merged 3 commits into from
Oct 25, 2023
Merged

New publish workflow #81

merged 3 commits into from
Oct 25, 2023

Conversation

tsmbland
Copy link
Member

@tsmbland tsmbland commented Oct 24, 2023

Description

Added a new workflow to publish on release. Steps are commented out so user can uncomment as desired or add different steps. Also added a few lines in the readme

Fixes #79

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@tsmbland
Copy link
Member Author

All done from my end, can't see anything else worth abstracting

Copy link
Collaborator

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Nice touch adding in the bit to the readme

@AdrianDAlessandro AdrianDAlessandro merged commit aa95405 into main Oct 25, 2023
10 checks passed
@AdrianDAlessandro AdrianDAlessandro deleted the publish branch October 25, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a publish workflow for building images on release
2 participants