-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable dynamic versions in pip-tools #184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've just added a couple of mutually exclusive improvements.
{{ cookiecutter.project_slug }}/{{ cookiecutter.project_slug }}/__init__.py
Outdated
Show resolved
Hide resolved
{{ cookiecutter.project_slug }}/{{ cookiecutter.project_slug }}/__init__.py
Outdated
Show resolved
Hide resolved
Having said that, it seems that setuptools is not happy with the change. |
Ok, I've fixed the tests. It required initialising the git repo before installing the package, and then a few adjustments... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR configures setuptools-scm to get the package versions dynamically from git tags in the pip-tools option.
Inspired by EnergySystemsModellingLab/MUSE_OS#596
Type of change
Key checklist
python -m pytest
)pre-commit run --all-files
)Further checks