Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dynamic versions in pip-tools #184

Merged
merged 9 commits into from
Dec 11, 2024
Merged

Conversation

AdrianDAlessandro
Copy link
Contributor

Description

This PR configures setuptools-scm to get the package versions dynamically from git tags in the pip-tools option.

Inspired by EnergySystemsModellingLab/MUSE_OS#596

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

Copy link
Contributor

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've just added a couple of mutually exclusive improvements.

@dalonsoa
Copy link
Contributor

dalonsoa commented Dec 6, 2024

Having said that, it seems that setuptools is not happy with the change.

@AdrianDAlessandro
Copy link
Contributor Author

Having said that, it seems that setuptools is not happy with the change.

Ok, I've fixed the tests. It required initialising the git repo before installing the package, and then a few adjustments...

Copy link
Collaborator

@alexdewar alexdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AdrianDAlessandro AdrianDAlessandro merged commit 8e0d230 into main Dec 11, 2024
9 checks passed
@AdrianDAlessandro AdrianDAlessandro deleted the dynamic-versions branch December 11, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants