Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stored XSS on ImpressCMS 1.4.0 #659

Closed
Applebois opened this issue Jun 18, 2020 · 11 comments · Fixed by #660
Closed

Stored XSS on ImpressCMS 1.4.0 #659

Applebois opened this issue Jun 18, 2020 · 11 comments · Fixed by #660
Assignees
Labels
bug security vulnerability Security vulnerability detected by WhiteSource
Milestone

Comments

@Applebois
Copy link

Payload = <script>alert('AppleBois');</script>

Vulnerable URL :modules/system/admin.php?fct=adsense&op=mod&adsenseid=4
Vulnerable TextBar : ID of the [adsense tag to display this ad]

Vulnerable URL :/modules/system/admin.php?fct=customtag&op=mod
Vulnerable TextBar : Name

Reference
https://medium.com/@tehwinsam/impresscms-1-4-0-3aaf1825e6d5

@fiammybe fiammybe self-assigned this Jun 19, 2020
@fiammybe fiammybe added this to the 1.4.1 milestone Jun 19, 2020
@fiammybe fiammybe added bug security vulnerability Security vulnerability detected by WhiteSource labels Jun 19, 2020
@fiammybe
Copy link
Member

Hi, the medium reference is not working.

Keep in mind that you have to be logged in and need to have access to the administration section before you have access to that page. Because of that, I consider it a low-risk vulnerability, but thank you for the ticket, I'll get on it straight away.

@Applebois
Copy link
Author

Applebois commented Jun 19, 2020 via email

@fiammybe
Copy link
Member

Yes,those are the administration functionalities that should only be handled by trusted admin users. As a matter of fact, it can be used to clean up database entries (for example to follow the retention period for certain data, you can run an autotask every day to remove old data).

@fiammybe
Copy link
Member

We have a presence on HackerOne : https://hackerone.com/impresscms . It is still in 'startup' phase because we haven't had enough vulnerability notifications passing through there in order to qualify for a full presence, but you can still use it if you want. You will need to create a HackerOne account though.
I will verify if that is mentioned in the security documentation. Follow-up there should be easier in the future.

@Applebois
Copy link
Author

Applebois commented Jun 19, 2020 via email

@fiammybe
Copy link
Member

Could you enter this bug report also there? It would give me an opportunity to see if everything works as expected :-)

@Applebois
Copy link
Author

Applebois commented Jun 19, 2020 via email

@fiammybe
Copy link
Member

Thanks! It's unclear to me how this works, the 'private' repository thing of HackerOne :-( We'll see what they anwser

@Applebois
Copy link
Author

Alright.

@Applebois
Copy link
Author

amigo, below is the reply from HackerOne.

Thank you for reaching out to HackerOne Support about submitting your report. We are not able to review or validate reports on behalf of the companies that use our platform or even our own program.

If the company is listed in our directory (https://hackerone.com/directory) we recommend that you go to their page and submit the report through the method they have provided. If the program has a pink submit button they have a program on our platform.

If they have a directory page but are not using our platform then they will be a community updated page. These community updated pages have the following message on them:

'''HackerOne Directory [?]
Information is provided and moderated by members of the community. Accuracy has not been validated by HackerOne.'''

If the company does not have a directory page with us you may want to try reporting it to our Disclosure Assistance team. You can find more information about how Disclosure Assistance works in this article:

https://docs.hackerone.com/programs/disclosure-assistance.html#___gatsby

@fiammybe
Copy link
Member

fiammybe commented Jul 7, 2020

Hi, I tested this under the 1.4.1 beta, and the behaviour is now as expected : the system does not execute the javascript, but simply shows it in the box. I think we can close this and release 1.4.1 final then.

@fiammybe fiammybe linked a pull request Jul 7, 2020 that will close this issue
@fiammybe fiammybe closed this as completed Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug security vulnerability Security vulnerability detected by WhiteSource
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants