Using FireWall middleware for bad ips checking instead of Security class #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool :-) I just saw that a recent mentioned Laravel package does the same thing more or less : https://github.com/Mahmoud-Italy/Larasecure-ipblocker |
…r-bad-ips-from-middleware
…r-bad-ips-from-middleware
…r-bad-ips-from-middleware
…r-bad-ips-from-middleware
…r-bad-ips-from-middleware
…r-bad-ips-from-middleware
fiammybe
approved these changes
Dec 10, 2020
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From now bad IPs checking uses https://github.com/middlewares/firewall that lets better to define single IPs or IPs ranges that should be banned.
Also from security class removed
checkBadIpmethod.Closes #703
Warning: This pull request must be merged after #717 (it's based on this pull request code)