Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option "deleteRegionFilesAfterAccess" not working #231

Closed
VaclavKlima opened this issue Jul 20, 2022 · 1 comment · Fixed by #239
Closed

Option "deleteRegionFilesAfterAccess" not working #231

VaclavKlima opened this issue Jul 20, 2022 · 1 comment · Fixed by #239
Labels
bug Something isn't working

Comments

@VaclavKlima
Copy link

VaclavKlima commented Jul 20, 2022 •
edited
Loading

Description

Today I looked at the cache folder and it had 36Gb of data which means that the plugin is not deleting old data...
I looked in the config and I had the default value for the "deleteRegionFilesAfterAccess" (2 days).
Then I looked in the folder and found files that were updated a month ago and so on...

Reproduction Steps

Cache some chunks and then don't load them for more than the set value "deleteRegionFilesAfterAccess"

Expected Behaviour

The old cache should be deleted after expiry duration

Server Details

git-Purpu-1610 mc ver: 1.18.2

Orebfuscator Version

5.2.6

ProtocolLib Version

4.8.0

Logs and Configs

config.txt

Extra Details

I'm reporting this bug because the backup of the server was 2x bigger than it should...

For now, I just moved the "baseDirectory" to another folder so I don't have to backup server with the cache
@VaclavKlima VaclavKlima added the bug Something isn't working label Jul 20, 2022
@Ingrim4
Copy link
Member

Ingrim4 commented Jul 20, 2022

I haven't done any testing yet but cache files only get deleted if the file's lastAccessTime is older then the configured value. So are you sure the files haven't been accessed in the last 2 days?

Ingrim4 added a commit that referenced this issue Sep 8, 2022
@Ingrim4
feat(#231): add 'enableDiskCache' option
8db5c8a 
feat(#234): remove chunk invaldation from game thread
feat(#230): fix some rare NPE in plugin shutdown
@Ingrim4 Ingrim4 mentioned this issue Sep 8, 2022
Merged
3 tasks
Ingrim4 added a commit that referenced this issue Sep 10, 2022
@Ingrim4
[#231, #234, #230] Minor cache revamp (#239)
b8240cb 
feat(#231): add 'enableDiskCache' option
feat(#234): remove chunk invaldation from game thread
feat(#230): fix some rare NPE in plugin shutdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#231, #234, #230] Minor cache revamp Imprex-Development/orebfuscator
2 participants
@Ingrim4 @VaclavKlima