Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#165] Fix async packet ordering #308

Merged
merged 3 commits into from
Aug 17, 2023
Merged

[#165] Fix async packet ordering #308

merged 3 commits into from
Aug 17, 2023

Conversation

Ingrim4
Copy link
Member

@Ingrim4 Ingrim4 commented Aug 15, 2023

Description

Solves the following potential issues caused by invalid order of packets related to chunks:

  • memory leaks/permanently loaded chunks on clientside/ViaVersion
  • lost block entity updates
  • lighting issues in versions before 1.18

Related Issue

closes #165

How Has This Been Tested?

Successfully tested with the latest spigot version and latest 1.17.1 build

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

NgLoader
NgLoader previously approved these changes Aug 15, 2023
@Ingrim4 Ingrim4 merged commit 84119e3 into master Aug 17, 2023
@Ingrim4 Ingrim4 deleted the 165-fix-packet-order branch August 19, 2023 11:14
@Ingrim4 Ingrim4 mentioned this pull request Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No light data found for chunk...
2 participants