Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppGallery URL gets malformed #1570

Closed
StSav012 opened this issue Apr 24, 2024 · 1 comment
Closed

AppGallery URL gets malformed #1570

StSav012 opened this issue Apr 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@StSav012
Copy link

Prerequisites
Either GitHub search fails or this is a new issue indeed.

Describe the bug

In an AppGallery URL, there may be the cloud part already present. Without the proper check, the app adds the part into the URL. This may result in a malformed URL and the corresponding error:

ClientException with SocketException: Failed host lookup: 'appgallery.cloud.cloud.huawei.com' (OS Error: No address associated with hostname, errno = 7), uri=https://appgallery.cloud.cloud.huawei.com/appdl/C000000000

To Reproduce

  1. Go to the main screen.
  2. Tap on Add App
  3. In the App Source URL field, enter https://appgallery.cloud.huawei.com/appdl/C000000000 (or with a valid app number)
  4. Select Override Source to Huawei AppGallery.
  5. Click the Add button.
  6. See the error message.

Please complete the following information:

  • Device: Motorola moto g¹⁰⁰ (XT2125-4)
  • OS: Android 12 (S1RTS32.41-20-16-1-9)
  • Obtainium Version: 1.1.6

Additional context
When I enter the URL I can get from the browser (like https://appgallery.huawei.com/#/app/C000000000), the app complains that the URL is invalid. The trick is to replace the /#/app/ part with /appdl/. This is not trivial. Please consider the fix for that, too.

@StSav012 StSav012 added bug Something isn't working to check Issue has not been reviewed labels Apr 24, 2024
@ImranR98 ImranR98 added TODO Issue to focus on for the next release and removed to check Issue has not been reviewed labels Apr 24, 2024
ImranR98 added a commit that referenced this issue May 6, 2024
- Add more links to the settings page (#1554)
- Support for more Huawei AppGallery URL schemes (#1570)
- Fix HTML release asset download (#1578)
- Fix non-APK GitHub release asset downloads (#1581)
- Fix asset date UI (#1590)
@ImranR98
Copy link
Owner

ImranR98 commented May 6, 2024

https://github.com/ImranR98/Obtainium/releases/tag/v1.1.7

@ImranR98 ImranR98 closed this as completed May 6, 2024
@ImranR98 ImranR98 removed the TODO Issue to focus on for the next release label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants