Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"FormatException: invalid port" for HTML source #1715

Closed
946923759 opened this issue Jul 11, 2024 · 2 comments
Closed

"FormatException: invalid port" for HTML source #1715

946923759 opened this issue Jul 11, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@946923759
Copy link

Describe the bug
I want to add an HTML source from a non default port, but it says this when trying to add it.

To Reproduce

  1. On a computer, do python3 -m http.server or some equivalent that runs a HTTP server on a port other than 80 or 443. And have some valid files in the folder, of course.
  2. Try adding it in Obtainium, in this case it was http://192.168.12.242:8000
  3. Despite the HTTP server showing it was accessed, the source cannot be added

Screenshots and Logs
Oddly, the / is also missing. Changing the source to http://192.168.12.242:8000/ does not fix it.

FormatException: Invalid port (at character 23)
http://192.168.12.242:8000testApp_v10.7.52.arm64.apk
                      ^

Please complete the following information:

  • Device: Surface Duo
  • OS: Android 12
  • Obtainium Version: 1.1.13
@946923759 946923759 added bug Something isn't working to check Issue has not been reviewed labels Jul 11, 2024
@946923759
Copy link
Author

After switching to a default port, the missing / seems to be causing issues with adding the source. The HTML looks like <a href="testApp_v10.7.52.eng-arm64.apk">testApp_v10.7.52.arm64.apk</a> (no / at the beginning)

It can be solved by writing a custom index.html, at least.

@ImranR98 ImranR98 added TODO Issue to focus on for the next release and removed to check Issue has not been reviewed labels Jul 14, 2024
ImranR98 added a commit that referenced this issue Jul 15, 2024
- Attempt bugfix for error when on VPN (#1120)
- Translation fixes (#1699)
- GitHub search bugfix (#1705)
- Fix missing trailing slash for path-less URLs (#1715)
- Rename Codeberg to Forgejo (#1722)
- Rename "Version String Extraction" to "Trim Version String" for non-HTML Sources (#1723)
@ImranR98
Copy link
Owner

@ImranR98 ImranR98 removed the TODO Issue to focus on for the next release label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants