Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub packages do not fall back to global GitHub token #1866

Closed
mordae opened this issue Sep 30, 2024 · 5 comments
Closed

GitHub packages do not fall back to global GitHub token #1866

mordae opened this issue Sep 30, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@mordae
Copy link

mordae commented Sep 30, 2024

Adding a GitHub package without specifying the access token in its options results in quota exceeded errors since the globally configured token is not used. One must repeat the token for every such package, which is tedious.

On top of that, it is impossible to change the per-package token, meaning after one finds that they have too many packages, one has to go through them all and re-add them.

Once the token expires, one would have to re-add all the packages to change the token as well.

  1. Please make it so that the packages fall back to the globally configured token.
  2. Remove the per-package token or make it editable so that one could replace it once it expires.
@mordae mordae added bug Something isn't working to check Issue has not been reviewed labels Sep 30, 2024
@ImranR98 ImranR98 added source-specific This bug/feature affects a specific source and removed to check Issue has not been reviewed labels Sep 30, 2024
@ImranR98
Copy link
Owner

Not sure what you mean by GitHub "package" - could you provide an example?

@ImranR98 ImranR98 removed the source-specific This bug/feature affects a specific source label Sep 30, 2024
@mordae
Copy link
Author

mordae commented Oct 1, 2024

Packages installed from GitHub releases. Added by searching GitHub from Obtainium.

For example Obtainium.

@mordae
Copy link
Author

mordae commented Oct 1, 2024

My case:

  1. Add a bunch of packages by searching GitHub.
  2. Quota exceeded.
  3. Add global token.
  4. Search goes fine, add or update gives quota exceeded.
  5. Remove all packages and add them with the same token explicitly repeated in their configuration.
  6. Worry I'd have to do it again in a year or so after the token expires.

@ImranR98

This comment was marked as outdated.

@ImranR98 ImranR98 added TODO Issue to focus on for the next release source-specific This bug/feature affects a specific source and removed source-specific This bug/feature affects a specific source labels Oct 1, 2024
ImranR98 pushed a commit that referenced this issue Oct 1, 2024
ImranR98 added a commit that referenced this issue Oct 1, 2024
- App-wide "pretend to be GPlay" option (#1859)
- UI bugfixes on add app page (#1866)
- UI tweaks (#1871, #1872)
- Added "skip latest" option to APKPure (also fallback toggle)
@ImranR98
Copy link
Owner

ImranR98 commented Oct 2, 2024

@ImranR98 ImranR98 closed this as completed Oct 2, 2024
@ImranR98 ImranR98 removed the TODO Issue to focus on for the next release label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants