Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APKPure apps are not filtered by architecture #598

Closed
maah opened this issue May 31, 2023 · 3 comments
Closed

APKPure apps are not filtered by architecture #598

maah opened this issue May 31, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@maah
Copy link

maah commented May 31, 2023

Apps from APKPure are not filtered by CPU architecture, and are wrongly detected as an update.
The APKPure download page specifies the supported architecture(s) of the (X)APK so this should be trivial to implement.

Example with Discord:

Obtainium will install v180.15, making Discord crash on launch (because of the architecture mismatch).

@ImranR98 ImranR98 added the enhancement New feature or request label Jun 1, 2023
@ImranR98
Copy link
Owner

ImranR98 commented Jun 3, 2023

Obtainium assumes that for any given version of an App, all architectures will be available. The latest version (along with all available APK URLs for that version) is grabbed, then that list is filtered for a specific architecture. That code applies to the "general" source on top of which all source-specific code is implemented. So reversing that for ApkPure is not so simple. Could probably be done through a "fallback to older releases" toggle like GitHub has, but not a high priority. Also not sure how/where the app would tell the user that APK filters work differently for APKPure compared to other sources.

@maah
Copy link
Author

maah commented Jun 3, 2023

Obtainium assumes that [...] all architectures will be available.

Which is never guaranteed for APKPure releases.

I'm not sure how Obtainium filters the version list, but since the supported architectures are show on the download page, unsupported ones could simply not be added to the list (as a workaround) in getLatestAPKDetails(), no?
Either way, a "fallback to older releases" is likely necessary for APKPure, as many (but not all) apps unfortunately have this issue.

A "preferred architecture" setting could work, and be used by other sources for automatic detection too (e.g filenames like
app-arm64-v8a-release.apk)

@ImranR98 ImranR98 added the TODO Issue to focus on for the next release label Aug 5, 2024
ImranR98 added a commit that referenced this issue Aug 5, 2024
- APKPure: Filter releases by available architecture (#598)
- Use a more obvious icon (magnifying glass) for the "filter apps" button (#1762)
@ImranR98
Copy link
Owner

ImranR98 commented Aug 5, 2024

https://github.com/ImranR98/Obtainium/releases/tag/v1.1.16

@ImranR98 ImranR98 closed this as completed Aug 5, 2024
@ImranR98 ImranR98 removed the TODO Issue to focus on for the next release label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants