Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add support for custom schema #918

Closed
FredHappyface opened this issue Sep 18, 2023 · 4 comments
Closed

Feature: Add support for custom schema #918

FredHappyface opened this issue Sep 18, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@FredHappyface
Copy link

Prerequisites

Describe the feature

Hi thanks for this awesome app

I was thinking it would be great to add an install with obtainium option to my repo for my app on GitHub and thought the best way to do this would be by creating a obtainium schema and adding it as a supported URL to Android. Not sure in the details but I was imagining something like

obtainium://url_encode(app_url)

Or

Https://obtainium.app/url_encode(app_url)

Where the schema is obtainium is supported by Android or https if custom schemas are not supported. In the event that Https is chosen, there may be an option to support redirects if using your own domain (though this may have security issues, in which case it may be more secure to choose an invalid domain with an invalid tld). The app URL may either be an encoded URL such as

https://github.com/ImranR98/Obtainium

Or could use a custom structure to more explicitly identify the app source?

source=github&url=https://github.com/ImranR98/Obtainium&name=Obtainium

For example (I can foresee a few issues with the example given for sources with URL params, though this may be mitigated using different symbology/ structure)

This would be great for raising awareness of obtainium as a valid app source

Describe alternatives you've considered (if applicable)

Leave things be and require a user to take a more explicit, manual, approach to adding apps may have certain security benefits as the expense of usability. Solving the issue of how to deal with what happens if the user doesn't have obtainium would be challenging to solve from a usability vs security perspective. For example using a custom schema might not be supported by the browser. Using an invalid http url may be confusing to the user

Additional context

Thanks for your time on this!

@FredHappyface FredHappyface added enhancement New feature or request to check Issue has not been reviewed labels Sep 18, 2023
@ImranR98
Copy link
Owner

ImranR98 commented Sep 19, 2023

Could be doable. Mentioning #109 as a related but different issue (link sharing vs. auto-open with custom URI).

@ImranR98 ImranR98 removed the to check Issue has not been reviewed label Sep 19, 2023
@ds-jetzt
Copy link

I would be happy to see the implementation.

First of all, a link of the kind "https://obtainium.app/url_encode(app_url)"" would be sufficient, where only obtainium is opened with the view "Add App" and the URL is already pre-filled.

In addition, a "Share" button on the info page of an installed app would be useful, which then generates exactly such a link.

These steps would certainly help the project, its distribution and use, and should be relatively easy to implement.

@pluja
Copy link

pluja commented Dec 5, 2023

This would be a great addition to Obtainium! I think using Android Verified Applinks is one way of achieving this (I'm not an Android dev). I see two main benefits on using a link shcema for Obtainium:

  • Apps could add Obtainium links to their repository, avoiding the need for third-party app stores and making Obtainium more noticeable.
  • Users would need just a click to add an app to Obtainium, improving the UX.

ImranR98 pushed a commit that referenced this issue Dec 16, 2023
@ImranR98 ImranR98 added the TODO Issue to focus on for the next release label Dec 16, 2023
ImranR98 added a commit that referenced this issue Dec 16, 2023
- Custom link support (#368, #918)
- Export settings (#1157)
- Use public GitLab search API (#1147)
- Fix unauthorized error (#1153)
@ImranR98
Copy link
Owner

Added. See #368.

@ImranR98 ImranR98 removed the TODO Issue to focus on for the next release label Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants