Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallelize refresh work #963

Closed
MatsG23 opened this issue Oct 6, 2023 · 6 comments
Closed

Parallelize refresh work #963

MatsG23 opened this issue Oct 6, 2023 · 6 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@MatsG23
Copy link

MatsG23 commented Oct 6, 2023

Is your feature request related to a problem? Please describe.
I have 31 apps registered in Obtainium. Refreshing the full app list takes a few minutes. This is also caused by some app entries taking a bit longer to refresh.

Describe the feature
I think the refresh speed could be increased by parallelizing the network requests to all the app sources. Right now due to the speed it seems like only one app source would be fetched at once.
@MatsG23 MatsG23 added enhancement New feature or request to check Issue has not been reviewed labels Oct 6, 2023
@ImranR98 ImranR98 added TODO Issue to focus on for the next release and removed to check Issue has not been reviewed labels Oct 6, 2023
ImranR98 added a commit that referenced this issue Oct 7, 2023
@ImranR98
Merge pull request #964 from ImranR98/963
d8cbc12 
Parallelize Update Checking (#963)
ImranR98 added a commit that referenced this issue Oct 7, 2023
@ImranR98
Merge pull request #965 from ImranR98/dev
c8f2f42 
Parallelize Update Checking (#963), Bugfixes (#954, #962)
@ImranR98
Copy link
Owner

ImranR98 commented Oct 7, 2023

https://github.com/ImranR98/Obtainium/releases/tag/v0.14.23-beta

@ImranR98 ImranR98 closed this as completed Oct 7, 2023
@ImranR98 ImranR98 removed the TODO Issue to focus on for the next release label Oct 7, 2023
@MatsG23
Copy link
Author

MatsG23 commented Oct 7, 2023

That's great! I am still wondered how you can implement everything so quick.

@ImranR98
Copy link
Owner

Just FYI, I had to switch back to serial update checking for background tasks. I'm not sure why but the parallel method seemed to cause some silent crash a lot of the time. Foreground checking (pull to refresh) still uses the parallel method and (which is the main UX improvement for this issue anyways - I'm guessing most people aren't checking how long background updates take). I'll try messing around with the BG process again at some point.

@ImranR98
Copy link
Owner

That doesn't seem to have fixed it. Might be an Android 14 issue (switched to it on both devices shortly after this change). If either of you are on Android <14 did you have any issues with parallel checking in the background task?

@ImranR98 ImranR98 mentioned this issue Oct 12, 2023
Closed
@ImranR98 ImranR98 reopened this Oct 12, 2023
@ImranR98 ImranR98 added the bug Something isn't working label Oct 12, 2023
@ImranR98
Copy link
Owner

Yeah, parallel updates weren't the issue - will switch back to them in the next release. Not sure why the tasks are crashing so often on my devices.

ImranR98 pushed a commit that referenced this issue Oct 14, 2023
Switch back to parallelized BG task (#963) + better logging
7f3e877
ImranR98 added a commit that referenced this issue Oct 14, 2023
@ImranR98
Merge pull request #1000 from ImranR98/dev
0a47d3e 
Switch back to parallelized BG task (#963), Make Third Party F-Droid Repos Searchable (#995)
@ImranR98
Copy link
Owner

Will track the task crashes on the existing issue #608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ImranR98 @MatsG23