-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Indonesia Translation #1868
Conversation
i guess it's better for us to get into discussion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i can't comment for every lines as most of the reason are same. however, the previous translation aims to sounds more natural to our user. most of the translation are misleading too.
there are some stuff to do after reviewing this PR.
- improve "rate limit" term by checking for how other app/project use the term to make it consistent with others.
- check whether "input" is a proper term in indonesian KBBI or not, to improve line 95.
assets/translations/id.json
Outdated
@@ -1,20 +1,20 @@ | |||
{ | |||
"invalidURLForSource": "Bukan URL aplikasi {} yang valid", | |||
"invalidURLForSource": "Bukan tautan aplikasi {} yang valid", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"link" mostly translated to "tautan". it's better to keep them as is imo.
assets/translations/id.json
Outdated
"noVersionFound": "Tidak dapat menentukan versi rilis", | ||
"urlMatchesNoSource": "Tautan tidak sesuai dengan sumber yang dikenal", | ||
"cantInstallOlderVersion": "Tidak dapat memasang versi lama dari aplikasi", | ||
"appIdMismatch": "Unduhan paket ID tidak sesuai dengan aplikasi yang ada", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't make sense. translates to "the package id download doesn't match with the current app". also, the actual intention is to tell user that the package id is different with current app's id.
assets/translations/id.json
Outdated
"appIdMismatch": "ID paket yang diunduh tidak sama dengan ID aplikasi yang ada", | ||
"noVersionFound": "Tidak dapat menentukan versi rilis", | ||
"urlMatchesNoSource": "Tautan tidak sesuai dengan sumber yang dikenal", | ||
"cantInstallOlderVersion": "Tidak dapat memasang versi lama dari aplikasi", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 4: same reason with line 6
line 5: same reason with line 2
line 6: even though the meaning is roughly same, that would sound unnatural. in my translation, "versi aplikasi" provides an initial explanation to the user that the subject we're discussing is about the version of the app itself. then we add the adjective at the end, "yang lebih lama". the "yang" here is to tell them about the old version.
assets/translations/id.json
Outdated
"ok": "Oke", | ||
"and": "dan", | ||
"githubPATLabel": "Token Akses Pribadi GitHub (tingkatkan batasan tarif)", | ||
"githubPATLabel": "Token Akses Pribadi GitHub (Meningkatkan Batas)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, the term for "rate limit" is hard to translate in a proper way. gotta look around of how other apps/project translate the term.
assets/translations/id.json
Outdated
"functionNotImplemented": "Kelas ini belum mengimplementasikan fungsi ini", | ||
"placeholder": "Tempat penampung", | ||
"someErrors": "Terjadi beberapa kesalahan", | ||
"unexpectedError": "Kesalahan tidak terduga", | ||
"someErrors": "Beberapa Kesalahan Terjadi", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's improper i guess? usually you would use "beberapa kesalahan terjadi" when there's additional context behind, like "beberapa kesalahan terjadi karena masalah pada server".
assets/translations/id.json
Outdated
"pickHighestVersionCode": "Pilih otomatis APK dengan versi kode tertinggi", | ||
"requiresCredentialsInSettings": "{} membutuhkan kredensial tambahan (di Pengaturan)", | ||
"checkOnStart": "Periksa pembaruan saat startup", | ||
"tryInferAppIdFromCode": "Coba menebak ID Aplikasi dari kode sumber", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 234: i agree that "menebak" here would be better.
assets/translations/id.json
Outdated
"requiresCredentialsInSettings": "{} membutuhkan kredensial tambahan (di Pengaturan)", | ||
"checkOnStart": "Periksa pembaruan saat startup", | ||
"tryInferAppIdFromCode": "Coba menebak ID Aplikasi dari kode sumber", | ||
"removeOnExternalUninstall": "Hapus otomatis aplikasi yang dicopot secara eksternal", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i partially agree using "hapus otomatis ..." is better and simpler. however "... yang dicopot secara eksternal" bits unclear. perhaps either
a. "hapus otomatis aplikasi yang dicopot pemasangannya dari luar"
b. "hapus otomatis aplikasi yang dicopot pemasangannya dari sumber eksternal"
assets/translations/id.json
Outdated
"matchGroupToUseForX": "Cocokkan grup yang akan digunakan untuk \"{}\"", | ||
"matchGroupToUse": "Cocokkan grup yang akan digunakan untuk reguler ekspresi terkait ekstraksi versi string", | ||
"bgUpdatesOnWiFiOnly": "Nonaktifkan pembaruan latar belakang saat tidak terhubung ke WiFi", | ||
"autoSelectHighestVersionCode": "Pilih otomatis APK dengan versionCode tertinggi", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 260: agree with this part "Pilih otomatis...". for "versionCode", i guess it's fine to be as is. other language uses their own translation too.
assets/translations/id.json
Outdated
"APKLinkHash": "Hash tautan APK", | ||
"directAPKLink": "Tautan APK langsung", | ||
"pseudoVersionInUse": "Versi semu sedang digunakan", | ||
"defaultPseudoVersioningMethod": "Metode Penomoran Versi Semu", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you forgot the "standard" part. albeit i was thinking about "metode standar dalam penomoran versi semu" is actually better, but it's mouthful. so keep as is i guess.
assets/translations/id.json
Outdated
"one": "{} dan 1 aplikasi lainnya mendapat pembaruan.", | ||
"other": "{} dan {} aplikasi lainnya mendapat pembaruan." | ||
"one": "{} dan 1 aplikasi lainnya memiliki pembaruan.", | ||
"other": "{} dan {} aplikasi lainnya memiliki pembaruan." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree for this one, because it's either "mendapatkan" or "memiliki".
Will wait for their response. |
I was trying to keep it consistent with the words used, simplifying it while preserving the context. If you find any text that feels incorrect, feel free to change it |
Corrected several words