Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Community App Sources" translation and button to Add App Screen #1882

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Erengun
Copy link

@Erengun Erengun commented Oct 2, 2024

Resolves #1727

This pull request introduces a new button labeled "Community App Sources" to the AddAppPage. When clicked, this button will open an external application with the URL: https://apps.obtainium.imranr.dev/. Translations for the "Community App Sources" label have been included for multiple languages to ensure international support.

Changes in this PR:

  • Added a "Community App Sources" button on the AddAppPage
  • Integrated translations for the button text across various languages
  • Launched an external URL when the button is clicked

Screenshots:

Dark Mode

Screenshot_dark

Light Mode

Screenshot_light

@ImranR98
Copy link
Owner

ImranR98 commented Oct 2, 2024

We already have a link to this on the settings page. I agree with putting it on the add app page too, but this button is too prominent. Maybe we could have it on the bottom right, styled similarly to the "Supported Sources" link. Shortened to something like "Crowdsourced App Configs", it should fit on one line on most screens.

@Erengun
Copy link
Author

Erengun commented Oct 3, 2024

Hey @ImranR98 , thanks for the feedback! As you suggested, I’ve moved the button to the bottom right and styled it similarly to the "Supported Sources" link. I’ve also shortened the text to "Crowdsourced App Configs", so it fits on one line on most screens.

To give you options, I’ve placed the button:

  • In a row at the bottom right (similar to "Supported Sources")
  • In a column, both with left alignment and center alignment for comparison.

Take a look at the screenshots below and let me know which placement you think works best:

Row aligned (Bottom Right)

Screenshot_row_aligned

Column Left aligned

Screenshot_column_left_aligned

Column Center aligned

Screenshot_column_center_aligned

@ImranR98
Copy link
Owner

ImranR98 commented Oct 3, 2024

Thanks. Row aligned (bottom right) looks good.

@Erengun
Copy link
Author

Erengun commented Oct 3, 2024

Then its committed and Ready for review. @ImranR98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Obtainium Apps to Add App Screen
2 participants