Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instead of opening a second chat window for a group, the existing one should be focussed #164

Closed
koppor opened this issue Aug 29, 2024 · 3 comments
Closed

Instead of opening a second chat window for a group, the existing one should be focussed #164

koppor opened this issue Aug 29, 2024 · 3 comments

Comments

@koppor
Copy link
Collaborator

koppor commented Aug 29, 2024 •
edited
Loading

image

PR JabRef#11666
InAnYan added a commit that referenced this issue Aug 31, 2024
@InAnYan
Fix for #164
7b5f23a
@InAnYan
Copy link
Owner

InAnYan commented Aug 31, 2024

I did some crazy coding!

Seems to work all right

@InAnYan InAnYan added the status: waiting-for-feedback The submitter needs to recheck the issue or provide more information about the issue label Aug 31, 2024
@koppor
Copy link
Collaborator Author

koppor commented Sep 3, 2024

I did not formulate right.

  1. Group "A". Chat with group --> should open chat window for Group A
  2. Group "A". Chat with group --> should focus existing chat window
  3. Group "B". Chat with group --> should open new chat window. This time for Group B
  4. Group "A". Chat with group --> should focus existing chat window (for Group A)
  5. Group "B". Chat with group --> should focus existing chat window (for Group B)

@koppor koppor removed the status: waiting-for-feedback The submitter needs to recheck the issue or provide more information about the issue label Sep 3, 2024
InAnYan added a commit that referenced this issue Sep 4, 2024
@InAnYan
Fix for #164
0894ccd
@InAnYan
Copy link
Owner

InAnYan commented Sep 4, 2024

Closing as fixed. This time I understood you correctly

@InAnYan InAnYan closed this as completed Sep 4, 2024
github-merge-queue bot pushed a commit to JabRef/jabref that referenced this issue Sep 4, 2024
@InAnYan @koppor
Chat with groups + AI chat UI and logic overhaul (#11666)
7f7726e 
* AI chat UI overhaul

* Chat history and AI chat overhaul

* Implement ingestion logic

* Implement ingestion logic

* Accept list of entries

* Group chat history logic

* Move components to folders and introduce AiPrivacyNoticeGuardedComponent

* Move components to folders and introduce AiPrivacyNoticeGuardedComponent

* Introduce EmbeddingModelGuardedComponent

* SummaryComponent overhaul

* Summarization logic overhaul

* Finish work on refactoring the summarization

* Introduce group chats

* Introduce group chat

* Refactor AI code

* AI chat UI overhaul

* Chat history and AI chat overhaul

* Implement ingestion logic

* Implement ingestion logic

* Accept list of entries

* Group chat history logic

* Move components to folders and introduce AiPrivacyNoticeGuardedComponent

* Move components to folders and introduce AiPrivacyNoticeGuardedComponent

* Introduce EmbeddingModelGuardedComponent

* SummaryComponent overhaul

* Summarization logic overhaul

* Finish work on refactoring the summarization

* Introduce group chats

* Introduce group chat

* Refactor AI code

* Fix GenerateEmbeddingsTask

* Introduce windows

* Refactor notifications

* No linting errors occurring

* Improve chat history component

* Discard changes to src/main/java/module-info.java

* Refine JavaDoc

* Fix for InAnYan#173

* Fix for InAnYan#171

* Fix from code review

* Fix checkers

* Fix for InAnYan#175 and InAnYan#174

* Follow-up for InAnYan#175

* Fix for InAnYan#166

* Fix for InAnYan#164

* Fix checkers

* Fix from code review

* Update src/main/java/org/jabref/gui/ai/components/aichat/AiChatGuardedComponent.java

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

* Fix for InAnYan#166 and fix for InAnYan#176

* Might be fix for InAnYan#178

* Migrate from AbstractGroup to GroupTreeNode

* Fix for InAnYan#170

* Fix for InAnYan#164

* InAnYan#177

* Fix for InAnYan#180

* Fix checkers

* Fix the system message

* Fix for InAnYan#180

* Fix context menu order

* Fix `startsWith`

* Fix system message

* Fix for ProgressCounter

* Fix for system message

---------

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@koppor @InAnYan