Fix some of FindBugs findings.

Change-Id: I2294160bd30729fff49c1645eff2764689e277bd Reviewed-by: Benoit Sigoure <tsuna@stumbleupon.com> Tested-by: Benoit Sigoure <tsuna@stumbleupon.com>
InMobi · Mar 16, 2011 · 0cffb47 · 0cffb47
1 parent ee6f07f
commit 0cffb47
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 12 deletions.
diff --git a/src/core/RowSeq.java b/src/core/RowSeq.java
@@ -68,7 +68,6 @@ final class RowSeq implements DataPoints {
  */
  void setRow(final ArrayList<KeyValue> row) {
  final byte[] key = row.get(0).key();
- final long base_time = Bytes.getUnsignedInt(key, tsdb.metrics.width());
 
  if (this.key == null) {
  this.key = key;

diff --git a/src/core/TsdbQuery.java b/src/core/TsdbQuery.java
@@ -316,11 +316,7 @@ private DataPoints[] groupByAndAggregate(final TreeMap<byte[], Span> spans) {
  // - one for the LOL-OMG combination: [0, 0, 1, 0, 0, 4] and,
  // - one for the LOL-WTF combination: [0, 0, 1, 0, 0, 3].
  final ByteMap<SpanGroup> groups = new ByteMap<SpanGroup>();
- final short metric_ts_bytes = (short) (tsdb.metrics.width()
- + Const.TIMESTAMP_BYTES);
- final short name_width = tsdb.tag_names.width();
  final short value_width = tsdb.tag_values.width();
- final short tag_bytes = (short) (name_width + value_width);
  final byte[] group = new byte[group_bys.size() * value_width];
  for (final Map.Entry<byte[], Span> entry : spans.entrySet()) {
  final byte[] row = entry.getKey();

diff --git a/src/tsd/RpcHandler.java b/src/tsd/RpcHandler.java
@@ -276,7 +276,7 @@ public String toString() {
  }
 
  /** The "exit" command. */
- private final class Exit implements TelnetRpc {
+ private static final class Exit implements TelnetRpc {
  public Deferred<Object> execute(final TSDB tsdb, final Channel chan,
  final String[] cmd) {
  chan.disconnect();
@@ -483,10 +483,10 @@ private void logError(final HttpQuery query, final String msg) {
  LOG.error(query.channel().toString() + ' ' + msg);
  }
 
- private static void logError(final HttpQuery query, final String msg,
- final Exception e) {
- LOG.error(query.channel().toString() + ' ' + msg, e);
- }
+ //private static void logError(final HttpQuery query, final String msg,
+ // final Exception e) {
+ // LOG.error(query.channel().toString() + ' ' + msg, e);
+ //}
 
  //private void logInfo(final Channel chan, final String msg) {
  // LOG.info(chan.toString() + ' ' + msg);

diff --git a/src/tsd/client/DateTimeBox.java b/src/tsd/client/DateTimeBox.java
@@ -108,7 +108,7 @@ public DateTimeBox() {
  /**
  * A {@link DatePicker} with a customized UI for time support.
  */
- private final static class DateTimePicker extends DatePicker {
+ private static final class DateTimePicker extends DatePicker {
 
  /** DateTimeBox this picker belongs to. */
  private DateTimeBox box;

diff --git a/src/uid/UniqueId.java b/src/uid/UniqueId.java
@@ -392,7 +392,7 @@ public List<String> suggest(final String search) throws HBaseException {
  final byte[] key = row.get(0).key();
  final String name = fromBytes(key);
  final byte[] id = row.get(0).value();
- final String cached_name = idCache.get(id);
+ final String cached_name = idCache.get(new String(id));
  if (cached_name == null) {
  addIdToCache(name, id);
  addNameToCache(id, name);