Skip to content
This repository has been archived by the owner on Dec 22, 2024. It is now read-only.

Deprecating this plugin #60

Closed
InSyncWithFoo opened this issue Jun 23, 2024 · 6 comments
Closed

Deprecating this plugin #60

InSyncWithFoo opened this issue Jun 23, 2024 · 6 comments
Assignees
Labels
other Things that do not fit elsewhere

Comments

@InSyncWithFoo
Copy link
Owner

As I have partially explained in #57, I intend to deprecate this plugin and migrate all of its features to its sister.

I have been maintaining them for about 4 months now, and the experience so far is not quite good. Repeating almost everything twice is terribly tedious. I know I have made a mistake publishing them both. I know I should not ask my users to waste their time on something which should have been done without them noticing. I'm sorry.

To fix this problem, I'll merge them into one and archive this repository for good. Users should migrate to the new plugin going forward. Until that becomes a reality, I'll continue to keep this plugin alive. There will be no other major releases.

In case someone wants to keep using this plugin, releases from v1.0.0 and later will be installable on 2024.1 and all later versions, regardless of whether they are truly incompatible or not.

@ReHoss
Copy link

ReHoss commented Nov 21, 2024

As I have partially explained in #57, I intend to deprecate this plugin and migrate all of its features to its sister.

I have been maintaining them for about 4 months now, and the experience so far is not quite good. Repeating almost everything twice is terribly tedious. I know I have made a mistake publishing them both. I know I should not ask my users to waste their time on something which should have been done without them noticing. I'm sorry.

To fix this problem, I'll merge them into one and archive this repository for good. Users should migrate to the new plugin going forward. Until that becomes a reality, I'll continue to keep this plugin alive. There will be no other major releases.

In case someone wants to keep using this plugin, releases from v1.0.0 and later will be installable on 2024.1 and all later versions, regardless of whether they are truly incompatible or not.

I have both installed, I thought they were complementary lol.
@InSyncWithFoo , should I safely delete this one now?

@InSyncWithFoo
Copy link
Owner Author

InSyncWithFoo commented Nov 21, 2024

I have both installed, I thought they were complementary lol

I am... not so glad to inform you that this might cause minor problems for the configuration migrators, in the case you have custom settings for both of them. Worst case, you will have to migrate a few old settings manually if you want those back (you can find them in .idea/pyright.xml, .idea/pyright-langserver.xml and the IDE's configuration directory).

As the creator, this is my blame to take, for which I have just suffered the divine punishment of rewriting some 4000 LOC; I could only hope for your forgiveness.

[...] should I safely delete this one now?

If you don't mind, would you like to try out the new build right now? If you do, uninstall both, then download the new build from here (scroll to Artifacts at the bottom of the page) and install it manually. Important: Restart the IDE to make sure the migrators run.

@ReHoss
Copy link

ReHoss commented Nov 21, 2024

I have both installed, I thought they were complementary lol

I am... not so glad to inform you that this might cause minor problems for the configuration migrators, in the case you have custom settings for both of them. Worst case, you will have to migrate a few old settings manually if you want those back (you can find them in .idea/pyright.xml, .idea/pyright-langserver.xml and the IDE's configuration directory).

As the creator, this is my blame to take, for which I have just suffered the divine punishment of rewriting some 4000 LOC; I could only hope for your forgiveness.

[...] should I safely delete this one now?

If you don't mind, would you like to try out the new build right now? If you do, uninstall both, then download the new build from here (scroll to Artifacts at the bottom of the page) and install it manually. Important: Restart the IDE to make sure the migrators run.

No worries, the plugin is very good, and when I say "complementary". I mean, I thought both had specific features. I do not use any specific config (except a pyrightconfig.json file).
I may try your build soon!

@CoreJa
Copy link

CoreJa commented Dec 13, 2024

Hi @InSyncWithFoo , I'm a new user of you plugin, currently trying my best to figure out if this plugin has been merged to its sister repo. I can see there's a PR that looks like it, and it is closed. But I'm also seeing that this issue has not been closed, nor does this repo has been archived.

I'm not pushing or anything, please don't feel any pressure. I'm just trying ask 2 things:

If the answers to these two questions are yes, perhaps it would be better to update some docs and README stuff. Just one line in the main repo would be great: features from pyright-langserver-for-pycharm has been already merged here.

Appreciate your work!

@CoreJa
Copy link

CoreJa commented Dec 13, 2024

My apologies, I can tell that those 2 questions are answered and they are YES. I just started used the main plugin and LSP stuff is right there. I also see docs that say migrate stuff. Sorry about the messages above.

Hi @InSyncWithFoo , I'm a new user of you plugin, currently trying my best to figure out if this plugin has been merged to its sister repo. I can see there's a PR that looks like it, and it is closed. But I'm also seeing that this issue has not been closed, nor does this repo has been archived.

I'm not pushing or anything, please don't feel any pressure. I'm just trying ask 2 things:

If the answers to these two questions are yes, perhaps it would be better to update some docs and README stuff. Just one line in the main repo would be great: features from pyright-langserver-for-pycharm has been already merged here.

Appreciate your work!

@InSyncWithFoo
Copy link
Owner Author

@CoreJa No worries! It's confusing to leave both lying around, indeed.

This repository is effectively archived. I'll see if I could publish the last release within this week or the next to end its life for good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
other Things that do not fit elsewhere
Projects
None yet
Development

No branches or pull requests

3 participants