fabric, take 3 or something

[zml2008]

Re-opening based on the previous PR

This is a basic implementation that can register commands, but doesn't have any fancy argument types. I'm hoping to add that eventually. I'll probably go about that by allowing argument parsers to delegate to Brigadier types, since that will be easier, and allow for easier integration with mods that provide their own Brigadier argument types.

Argument type support

This PR aims to implement all Vanilla argument types (besides the development-only ones), primarily through wrapping the Brigadier parsers. Current progress:

Exist in Cloud

• UUIDArgumentType (network: minecraft:uuid)

Directly mapped

• ColorArgument (network: minecraft:color)
• CompoundTagArgument (network: minecraft:nbt_compound_tag)
• NbtTagArgument (network: minecraft:nbt_tag)
• NbtPathArgument (network: minecraft:nbt_path) todo: the actual implementation for this is an inner class of the brigadier type, does it make sense to wrap that?
• ScoreboardCriteriaArgument (network: minecraft:objective_criteria)
• ScoreboardOperationArgument (network: minecraft:operation)
• ParticleEffectArgument (network: minecraft:particle)
• AngleArgument (network: minecraft:angle) todo: the vanilla impl is logical server-only, but doesn't need to be
• AxisArgument (network: minecraft:swizzle)
• IdentifierArgument (network: minecraft:resource_location)
• EntityAnchorArgument (network: minecraft:entity_anchor)
• IntRangeArgument (network: minecraft:int_range)
• FloatRangeArgument (network: minecraft:float_range)
• ItemStackArgument (network: minecraft:item_stack) todo: this might want a wrapper -- it's not a full item stack, just the item type and NBT tag

Need wrapper type

These Brigadier parsers only return an intermediate type, and require a ServerCommandSource to be fully resolved. We need to evaluate which ones actually need a server, which can be made client-friendly. I expect everything that uses selectors will have to be server-only, but others can be client-friendly

These would also be bound to a ServerCommandSource sender type, or would need to provide a mapper function.

Using selectors

• ScoreHolderArgument (network: minecraft:score_holder) -- single vs multiple, anything that can be on a scoreboard (all wildcarding is done based on selector matches)
• EntityArgument (network: minecraft:entity) -- supports entity/player, and single/multiple properties
• MessageArgument (network: minecraft:message) -- this is just a greedy string that resolves selectors
• GameProfileArgument (network: minecraft:game_profile) - parses selectors

Using relative positions

• BlockPosArgument (network: minecraft:block_pos) - can be relative
• ColumnPosArgument (network: minecraft:column_pos) - can be relative
• Vec3dArgument (network: minecraft:vec3) - can be relative
• Vec2fArgument (network: minecraft:vec2) - can be relative

Others/to be sorted

• BlockPredicateArgument (network: minecraft:block_predicate)
• BlockStateArgument (network: minecraft:block_state)
• ItemPredicateArgument (network: minecraft:item_predicate)
• ScoreboardObjectiveArgument (network: minecraft:objective)
• RotationArgument (network: minecraft:rotation)
• ScoreboardSlotArgument (network: minecraft:scoreboard_slot)
• TeamArgument (network: minecraft:team)
• ItemSlotArgument (network: minecraft:item_slot)
• CommandFunctionArgument (network: minecraft:function)
• TimeArgument (network: minecraft:time) -- time in ticks

Combined to one registry values argument

These are all specialized argument types that can be exposed as one single argument type in-API. We'll be able to send the appropriate argument type/suggestion provider to be used for completions though, falling back to querying the server.

• EntityTypeArgument (network: minecraft:entity_summon)
• AVAILABLE_SOUNDS suggestion provider
• ALL_BIOMES suggestion provider
• SUMMONABLE_ENTITIES (all entities but player and fishing bobber)
• EnchantmentArgument (network: minecraft:item_enchantment) (needs to be re-implemented)
• ServerWorldArgument (network: minecraft:dimension)
• StatusEffectArgument (network: minecraft:mob_effect) (needs to be re-implemented)

Doesn't exist as an argument type, but is a client-local completion provider

• ALL_RECIPES

Entirely custom

Some parsers that might be useful for mod developers but aren't included in base Cloud:

• RegistryEntryArgument -- any entry in a registry, should support both static and dynamic registries

Other odds and ends

• Register mapped argument parsers with Brigadier
• Add support for split server/sent to client command trees, so the server doesn't double-parse
• Integrate with client commands api once Client-sided commands FabricMC/fabric#1115 is merged

[broccolai]

LGTM, test mod seems to work from my limited fabric knowledge too

[jpenilla]

Ready for merge in my opinion, pending review from @Citymonstret and @zml2008