Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@Quoted annotation for string arguments in annotated methods #239

Merged
merged 2 commits into from
Mar 18, 2021
Merged

@Quoted annotation for string arguments in annotated methods #239

merged 2 commits into from
Mar 18, 2021

Conversation

jpenilla
Copy link
Member

@jpenilla jpenilla commented Mar 18, 2021 •
edited
Loading

No description provided.

@jpenilla jpenilla requested a review from broccolai March 18, 2021 03:58
@jpenilla
Copy link
Member Author

does it make sense to throw an exception here if both quoted and greedy are applied to one value?

probably yes

@broccolai broccolai merged commit 24ae6f1 into 1.5.0-dev Mar 18, 2021
@broccolai broccolai deleted the features/1.5.0/quoted-string-annotation branch March 18, 2021 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broccolai broccolai broccolai approved these changes

@zml2008 zml2008 zml2008 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpenilla @zml2008 @broccolai