fabric: Support 1.19 #356
Merged
fabric: Support 1.19 #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpenilla
force-pushed
the
feature/fabric-1.19
branch
2 times, most recently
from
a57a67e to
b95b090
Compare
jpenilla
force-pushed
the
feature/fabric-1.19
branch
from
84f5245 to
d659ca8
Compare
jpenilla
force-pushed
the
feature/fabric-1.19
branch
from
d659ca8 to
e26fbf6
Compare
|
@jpenilla you probably need per-CommandManager keying on the build context supplier - otherwise you might run into issues with multiple mods using cloud at once |
This drops support for older Minecraft versions, due to breaking changes in Fabric API and new needs of MC command arguments.
jpenilla
force-pushed
the
feature/fabric-1.19
branch
from
96790ab to
ee11e57
Compare
jpenilla
added a commit
that referenced
this pull request
Jun 19, 2022
Co-authored-by: Jason Penilla <11360596+jpenilla@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops support for older Minecraft versions.
The CommandRegistrationContext changes on the MC side are a bit awkward as well -- I tried to integrate them into Cloud's parsers without breaking any existing api, but the way the context is collected is quite fragile. It currently doesn't work to pass registry access along to client commands either.
@jpenilla any ideas on how to pass this along to various arguments better?