Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(annotations): add command containers #364

Merged
merged 1 commit into from
May 31, 2022

Conversation

Citymonstret
Copy link
Member

This is the first part of the introduction of annotation processing to cloud. A new @CommandContainer annotation has been introduced, which can be placed on classes to have the annotation parser automatically construct & parse the classes when AnnotationParser.parseContainers() is invoked.

A future PR will introduce another processor that will scan for @CommandMethod annotations and verify the integrity of the annotated methods (visibility, argument annotations, etc.).

This is the first part of the introduction of annotation processing to cloud. A new `@CommandContainer` annotation has been introduced, which can be placed on classes to have the annotation parser automatically construct & parse the classes when `AnnotationParser.parseContainers()` is invoked.

A future PR will introduce another processor that will scan for `@CommandMethod` annotations and verify the integrity of the annotated methods (visibility, argument annotations, etc.).
@Citymonstret Citymonstret added this to the 1.7.0 milestone May 29, 2022
@github-actions
Copy link

Unit Test Results

  44 files  +1    44 suites  +1   5s ⏱️ -1s
197 tests +1  197 ✔️ +1  0 💤 ±0  0 ±0 
198 runs  +1  198 ✔️ +1  0 💤 ±0  0 ±0 

Results for commit 0489796. ± Comparison against base commit bcc9d30.

@phinner
Copy link
Contributor

phinner commented May 29, 2022

My god, this feature is awesome!

@Citymonstret Citymonstret merged commit 8a7dcd2 into 1.7.0-dev May 31, 2022
@Citymonstret Citymonstret deleted the feature/1.7.0/annotation-processing branch May 31, 2022 13:37
Citymonstret added a commit that referenced this pull request Jun 3, 2022
This is the first part of the introduction of annotation processing to cloud. A new `@CommandContainer` annotation has been introduced, which can be placed on classes to have the annotation parser automatically construct & parse the classes when `AnnotationParser.parseContainers()` is invoked.

A future PR will introduce another processor that will scan for `@CommandMethod` annotations and verify the integrity of the annotated methods (visibility, argument annotations, etc.).
jpenilla pushed a commit that referenced this pull request Jun 19, 2022
This is the first part of the introduction of annotation processing to cloud. A new `@CommandContainer` annotation has been introduced, which can be placed on classes to have the annotation parser automatically construct & parse the classes when `AnnotationParser.parseContainers()` is invoked.

A future PR will introduce another processor that will scan for `@CommandMethod` annotations and verify the integrity of the annotated methods (visibility, argument annotations, etc.).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants