Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): flag yielding arguments #367

Merged
merged 1 commit into from
Jun 6, 2022
Merged

feat(core): flag yielding arguments #367

merged 1 commit into from
Jun 6, 2022

Conversation

Citymonstret
Copy link
Member

@Citymonstret Citymonstret commented Jun 5, 2022 •
edited
Loading

Implements #218
Also confirmed to fix #321.

Both StringArgument and StringArrayArgument now have flag-yielding modes. For annotated command method users, this can be activated using ´@FlagYielding`

@Citymonstret Citymonstret added this to the 1.7.0 milestone Jun 5, 2022
@Citymonstret Citymonstret linked an issue Jun 5, 2022 that may be closed by this pull request
New string type: Greedy until flag start #218
Closed
@Citymonstret Citymonstret changed the title feat(core): flag string parser mode (GREEDY_FLAG_AWARE) feat(core): flag aware string parser mode (GREEDY_FLAG_AWARE) Jun 5, 2022
@github-actions
Copy link

github-actions bot commented Jun 5, 2022 •
edited
Loading

Unit Test Results

  47 files  +2    47 suites  +2   6s ⏱️ -1s
210 tests +7  210 ✔️ +7  0 💤 ±0  0 ❌ ±0 
211 runs  +7  211 ✔️ +7  0 💤 ±0  0 ❌ ±0 

Results for commit 9a7476f. ± Comparison against base commit c3c920f.

♻️ This comment has been updated with latest results.

@Citymonstret Citymonstret force-pushed the feature/1.7.0/flag-aware-parsers branch 3 times, most recently from 70efde5 to 5ccb149 Compare June 6, 2022 05:16
@Citymonstret Citymonstret linked an issue Jun 6, 2022 that may be closed by this pull request
Flags cannot succeed a StringArrayArgument #321
Closed
@Citymonstret Citymonstret marked this pull request as ready for review June 6, 2022 05:17
@Citymonstret Citymonstret enabled auto-merge (squash) June 6, 2022 05:17
@Citymonstret Citymonstret force-pushed the feature/1.7.0/flag-aware-parsers branch 2 times, most recently from a55ff74 to 38a0e1b Compare June 6, 2022 05:30
@Citymonstret Citymonstret disabled auto-merge June 6, 2022 05:32
@Citymonstret Citymonstret force-pushed the feature/1.7.0/flag-aware-parsers branch 2 times, most recently from 24b95bd to 0a609e2 Compare June 6, 2022 05:44
@Citymonstret
feat(core): flag yielding arguments
9a7476f 
Implements #218
Also confirmed to fix #321.

Both `StringArgument` and `StringArrayArgument` now have flag-yielding modes. For annotated command method users, this can be activated using ´@FlagYielding`
@Citymonstret Citymonstret force-pushed the feature/1.7.0/flag-aware-parsers branch from 0a609e2 to 9a7476f Compare June 6, 2022 05:44
@Citymonstret Citymonstret changed the title feat(core): flag aware string parser mode (GREEDY_FLAG_AWARE) feat(core): flag yielding arguments Jun 6, 2022
@Citymonstret Citymonstret added the enhancement New feature or request label Jun 6, 2022
@Citymonstret Citymonstret merged commit 990fbe7 into 1.7.0-dev Jun 6, 2022
@Citymonstret Citymonstret deleted the feature/1.7.0/flag-aware-parsers branch June 6, 2022 05:49
jpenilla pushed a commit that referenced this pull request Jun 19, 2022
@Citymonstret @jpenilla
feat(core): flag yielding arguments (#367)
d4ab593 
Implements #218
Also confirmed to fix #321.

Both `StringArgument` and `StringArrayArgument` now have flag-yielding modes. For annotated command method users, this can be activated using ´@FlagYielding`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Flags cannot succeed a StringArrayArgument New string type: Greedy until flag start
1 participant
@Citymonstret