Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command unregistration process unregisters all command nodes from the backing tree based on all childs of a root command. As the Node#equals & Node#hashCode functions are only implemented based on the name of a node, unregistering a command which has (for example) the same literal argument name as a root node will cause the unregister process to remove the root node instead of the child from the parent node.
The root boolean which is now passed to the
deleteRecursively
method seems to be the safest way to check if the specified node should be unregistered from the root command tree, however checking ifnode.getParent == internalTree
would do the job as well.