fix invalid suggestions when parsing of argument fails #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derklaro
commented
Nov 1, 2022
| @@ -390,7 +404,7 @@ void testLiteralWithVariable() { | |||
| Assertions.assertEquals(Arrays.asList("vici", "vidi"), suggestions3); | |||
| final String input4 = "literal_with_variable vidi"; | |||
| final List<String> suggestions4 = manager.suggest(new TestCommandSender(), input4); | |||
| Assertions.assertEquals(Collections.emptyList(), suggestions4); | |||
| Assertions.assertEquals(Collections.singletonList("vidi"), suggestions4); | |||
There was a problem hiding this comment.
This test was disabled & wrong previously. Without my change the test wouldn't pass as well as "vidi" would be given as a suggestion.
|
One thing I just tough of is that with this change the suggestion processor now pretty much relies on the fact that people are using the api correctly. While there shouldn't be any changes made to the command input queue during the (pre-) process, the whole check & further argument tries will fail if users are changing the queue. I will change that later, so that the queue gets reset in case of a (pre-) processing failure. |
|
Should be fine now |
|
Valid argument: Invalid argument: |
Citymonstret
approved these changes
Nov 28, 2022
jpenilla
approved these changes
Nov 28, 2022
jpenilla
pushed a commit
that referenced
this pull request
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current suggestion provider for dynamic arguments adds the suggestions of a failed parsed argument as well when stepping over it. This can for example be triggered when an integer argument is required, but a wrong value is provided. Consider the following case:
some_command <number <enum>. When the user inputs something likesome_command worldand tries to tab complete, the suggestions for the number argument show up. This is caused by a failed parse of the number argument, which doesn't step out of the current suggestion process for the argument, but rather continues to add all suggestions for it.To fix this behaviour, we need to break the completion process if either the preprocessor or the parser isn't accepting the input and more arguments are provided.