chore: unreleased changes

README.md

@@ -252,7 +252,7 @@ IncreaseClient client = IncreaseOkHttpClient.builder()
 
 ### Timeouts
 
-Requests time out after 60 seconds by default. You can configure this on the client builder:
+Requests time out after 1 minute by default. You can configure this on the client builder:
 
 ```java
 IncreaseClient client = IncreaseOkHttpClient.builder()

increase-java-client-okhttp/src/main/kotlin/com/increase/api/client/okhttp/IncreaseOkHttpClient.kt

@@ -21,6 +21,7 @@ class IncreaseOkHttpClient private constructor() {
 
         private var clientOptions: ClientOptions.Builder = ClientOptions.builder()
         private var baseUrl: String = ClientOptions.PRODUCTION_URL
+        // default timeout for client is 1 minute
         private var timeout: Duration = Duration.ofSeconds(60)
         private var proxy: Proxy? = null
 

increase-java-client-okhttp/src/main/kotlin/com/increase/api/client/okhttp/IncreaseOkHttpClientAsync.kt

@@ -21,6 +21,7 @@ class IncreaseOkHttpClientAsync private constructor() {
 
         private var clientOptions: ClientOptions.Builder = ClientOptions.builder()
         private var baseUrl: String = ClientOptions.PRODUCTION_URL
+        // default timeout for client is 1 minute
         private var timeout: Duration = Duration.ofSeconds(60)
         private var proxy: Proxy? = null
 

increase-java-client-okhttp/src/main/kotlin/com/increase/api/client/okhttp/OkHttpClient.kt

@@ -33,7 +33,13 @@ private constructor(private val okHttpClient: okhttp3.OkHttpClient, private val
 
     private fun getClient(requestOptions: RequestOptions): okhttp3.OkHttpClient {
         val timeout = requestOptions.timeout ?: return okHttpClient
-        return okHttpClient.newBuilder().callTimeout(timeout).build()
+        return okHttpClient
+            .newBuilder()
+            .connectTimeout(timeout)
+            .readTimeout(timeout)
+            .writeTimeout(timeout)
+            .callTimeout(if (timeout.seconds == 0L) timeout else timeout.plusSeconds(30))
+            .build()
     }
 
     override fun execute(
@@ -165,7 +171,8 @@ private constructor(private val okHttpClient: okhttp3.OkHttpClient, private val
     class Builder {
 
         private var baseUrl: HttpUrl? = null
-        private var timeout: Duration = Duration.ofMinutes(5)
+        // default timeout is 1 minute
+        private var timeout: Duration = Duration.ofSeconds(60)
         private var proxy: Proxy? = null
 
         fun baseUrl(baseUrl: String) = apply { this.baseUrl = baseUrl.toHttpUrl() }
@@ -176,7 +183,13 @@ private constructor(private val okHttpClient: okhttp3.OkHttpClient, private val
 
         fun build(): OkHttpClient {
             return OkHttpClient(
-                okhttp3.OkHttpClient.Builder().callTimeout(timeout).proxy(proxy).build(),
+                okhttp3.OkHttpClient.Builder()
+                    .connectTimeout(timeout)
+                    .readTimeout(timeout)
+                    .writeTimeout(timeout)
+                    .callTimeout(if (timeout.seconds == 0L) timeout else timeout.plusSeconds(30))
+                    .proxy(proxy)
+                    .build(),
                 checkNotNull(baseUrl) { "`baseUrl` is required but was not set" },
             )
         }

increase-java-core/src/main/kotlin/com/increase/api/models/BookkeepingEntrySetCreateParams.kt

@@ -207,7 +207,7 @@ constructor(
 
         private var date: OffsetDateTime? = null
         private var transactionId: String? = null
-        private var entries: List<Entry>? = null
+        private var entries: MutableList<Entry> = mutableListOf()
         private var additionalQueryParams: MutableMap<String, MutableList<String>> = mutableMapOf()
         private var additionalHeaders: MutableMap<String, MutableList<String>> = mutableMapOf()
         private var additionalBodyProperties: MutableMap<String, JsonValue> = mutableMapOf()
@@ -217,7 +217,7 @@ constructor(
             apply {
                 this.date = bookkeepingEntrySetCreateParams.date
                 this.transactionId = bookkeepingEntrySetCreateParams.transactionId
-                this.entries = bookkeepingEntrySetCreateParams.entries
+                this.entries(bookkeepingEntrySetCreateParams.entries)
                 additionalQueryParams(bookkeepingEntrySetCreateParams.additionalQueryParams)
                 additionalHeaders(bookkeepingEntrySetCreateParams.additionalHeaders)
                 additionalBodyProperties(bookkeepingEntrySetCreateParams.additionalBodyProperties)
@@ -233,7 +233,13 @@ constructor(
         fun transactionId(transactionId: String) = apply { this.transactionId = transactionId }
 
         /** The bookkeeping entries. */
-        fun entries(entries: List<Entry>) = apply { this.entries = entries }
+        fun entries(entries: List<Entry>) = apply {
+            this.entries.clear()
+            this.entries.addAll(entries)
+        }
+
+        /** The bookkeeping entries. */
+        fun addEntry(entry: Entry) = apply { this.entries.add(entry) }
 
         fun additionalQueryParams(additionalQueryParams: Map<String, List<String>>) = apply {
             this.additionalQueryParams.clear()

increase-java-core/src/main/kotlin/com/increase/api/models/EntityCreateParams.kt

@@ -329,7 +329,7 @@ constructor(
         private var trust: Trust? = null
         private var description: String? = null
         private var relationship: Relationship? = null
-        private var supplementalDocuments: List<SupplementalDocument>? = null
+        private var supplementalDocuments: MutableList<SupplementalDocument> = mutableListOf()
         private var additionalQueryParams: MutableMap<String, MutableList<String>> = mutableMapOf()
         private var additionalHeaders: MutableMap<String, MutableList<String>> = mutableMapOf()
         private var additionalBodyProperties: MutableMap<String, JsonValue> = mutableMapOf()
@@ -343,7 +343,7 @@ constructor(
             this.trust = entityCreateParams.trust
             this.description = entityCreateParams.description
             this.relationship = entityCreateParams.relationship
-            this.supplementalDocuments = entityCreateParams.supplementalDocuments
+            this.supplementalDocuments(entityCreateParams.supplementalDocuments ?: listOf())
             additionalQueryParams(entityCreateParams.additionalQueryParams)
             additionalHeaders(entityCreateParams.additionalHeaders)
             additionalBodyProperties(entityCreateParams.additionalBodyProperties)
@@ -382,7 +382,13 @@ constructor(
 
         /** Additional documentation associated with the entity. */
         fun supplementalDocuments(supplementalDocuments: List<SupplementalDocument>) = apply {
-            this.supplementalDocuments = supplementalDocuments
+            this.supplementalDocuments.clear()
+            this.supplementalDocuments.addAll(supplementalDocuments)
+        }
+
+        /** Additional documentation associated with the entity. */
+        fun addSupplementalDocument(supplementalDocument: SupplementalDocument) = apply {
+            this.supplementalDocuments.add(supplementalDocument)
         }
 
         fun additionalQueryParams(additionalQueryParams: Map<String, List<String>>) = apply {
@@ -448,7 +454,8 @@ constructor(
                 trust,
                 description,
                 checkNotNull(relationship) { "`relationship` is required but was not set" },
-                supplementalDocuments?.toUnmodifiable(),
+                if (supplementalDocuments.size == 0) null
+                else supplementalDocuments.toUnmodifiable(),
                 additionalQueryParams.mapValues { it.value.toUnmodifiable() }.toUnmodifiable(),
                 additionalHeaders.mapValues { it.value.toUnmodifiable() }.toUnmodifiable(),
                 additionalBodyProperties.toUnmodifiable(),

release-please-config.json

@@ -56,6 +56,9 @@
       "hidden": true
     }
   ],
+  "reviewers": [
+    "rattrayalex"
+  ],
   "release-type": "simple",
   "extra-files": [
     "README.md",