Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Poetry for dependency management system #182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adityasangave
Copy link
Contributor

Related Issue

Closes: #161

Describe the changes you've made

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

Screenshots

Original Updated
original screenshot updated screenshot

@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@lainq lainq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lainq
Copy link
Contributor

lainq commented Mar 28, 2022

Also i don't think you have the latest version of the source. There are missing commits

@adityasangave
Copy link
Contributor Author

@pranavbaburaj so should I close this one and start another?

@GouravSardana
Copy link
Member

@pranavbaburaj this is only one file right? It should not conflict.
@adii21-Ux can you add instruction in the readme - How to use it ?

@pranavbaburaj can we make a new branch “semi” and @adii21-Ux will point to semi branch instead of master

@adityasangave
Copy link
Contributor Author

@GouravSardana I will

Copy link
Member

@PradyumnaKrishna PradyumnaKrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GouravSardana this feature can be enable to update pull request branches.

@adii21-Ux pytest can be added as dev dependency using

poetry add -D pytest

simple-term-menu = "1.0.1"

[tool.poetry.dev-dependencies]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be added to enable command line functionality

Suggested change
[tool.poetry.scripts]
dynamic = "dynamic.__main__:main"

Comment on lines +32 to +40
{ include = "dynamic" },
{ include = "dynamic_cli.egg-info" },
{ include = "LICENSE" },
{ include = "poetry.lock" },
{ include = "pyproject.toml" },
{ include = "README.md" },
{ include = "setup.py" }
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these

description = "A Modern, user-friendly command-line HTTP client for the API testing, and if you're stuck - Search and browse StackOverflow without leaving the CLI"
authors = ["IndianOpenSourceFoundation"]
license = "General Public License GNU"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Packages should be mentioned here

Suggested change
packages = [{ include = "dynamic" }]

@lainq
Copy link
Contributor

lainq commented Mar 28, 2022

pranavbaburaj so should I close this one and start another?

No I think, as @GouravSardana not a big deal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Poetry for dependency management
4 participants