feature/implementing-ngrok-startup-script #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anwalker293 <alex.walker@indicio.tech>
Signed-off-by: anwalker293 <alex.walker@indicio.tech>
Signed-off-by: anwalker293 <alex.walker@indicio.tech>
dbluhm
requested changes
Nov 15, 2022
tunnel_endpoint.sh
Outdated
| WAIT_INTERVAL=${WAIT_INTERVAL:-3} | ||
| WAIT_ATTEMPTS=${WAIT_ATTEMPTS:-10} | ||
|
|
||
| retrieve_endpoint () { |
There was a problem hiding this comment.
This is more of a function that makes sure the server is ready rather than retrieving the endpoint.
tunnel_endpoint.sh
Outdated
| retrieve_endpoint () { | ||
| for _ in $(seq 1 "$WAIT_ATTEMPTS"); do | ||
| #TODO If wait attempts exceeded and we still haven't successfully gotten an endpoint, exit with status 1 | ||
| if ! curl -s -o /dev/null -w '%{http_code}' "${1}/url" | grep "200" > /dev/null; then |
There was a problem hiding this comment.
Suggested change
| if ! curl -s -o /dev/null -w '%{http_code}' "${1}/url" | grep "200" > /dev/null; then | |
| if ! curl -s -o /dev/null -w '%{http_code}' "${1}" | grep "200" > /dev/null; then |
I think we need to remove the /url so the function args can specify the endpoint fully and not have anything appended to it.
tunnel_endpoint.sh
Outdated
|
|
||
| retrieve_endpoint () { | ||
| for _ in $(seq 1 "$WAIT_ATTEMPTS"); do | ||
| #TODO If wait attempts exceeded and we still haven't successfully gotten an endpoint, exit with status 1 |
There was a problem hiding this comment.
I think we should implement this TODO. In the branch where we do the waiting, we should check if current number of attempt is equal to max and then exit 1 if it is.
Signed-off-by: anwalker293 <alex.walker@indicio.tech>
Signed-off-by: anwalker293 <alex.walker@indicio.tech>
Signed-off-by: anwalker293 <alex.walker@indicio.tech>
Signed-off-by: anwalker293 <alex.walker@indicio.tech>
Signed-off-by: anwalker293 <alex.walker@indicio.tech>
Signed-off-by: anwalker293 <alex.walker@indicio.tech>
Signed-off-by: Alex Walker <alex.walker@indicio.tech>
Also making requested changes Signed-off-by: Alex Walker <alex.walker@indicio.tech>
|
@dbluhm I think this is ready to rock and roll :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexandra N. Walker alex.walker@indicio.tech ☀️