fix: multi-use OOB invitations #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
mepeltier
approved these changes
Nov 17, 2022
|
As an aside, I noticed that the invitation message ID was not getting set on the newly created connection record. I had to use the invitation key as the correlation back to the original OOB invite. It works but I think it would be semantically more precise for the invitation message id to be set on the connection and use that. @mepeltier perhaps we should look at tweaking this behavior in ACA-Py? Maybe it's already something in main; I ran against 1.0.0 rc0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mepeltier see if this fixes your issues! 🙂