fix/protocols #42
Merged
fix/protocols #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Walker <alex.walker@indicio.tech>
Signed-off-by: Alex Walker <alex.walker@indicio.tech>
|
(Seems like not passing the tests/Tests thing, due to an import error in |
|
Please merge the PR changing tests/tests_protocols.py (#44) into this PR 🙂 |
fix: test_protocols.py
|
The format and lint check failure is a result of recent updates to the GHA pipeline (python 3.6 is no longer available on the latest ubuntu image) -- I think we can bump the version of python getting set up from 3.6 to 3.7 to fix |
Signed-off-by: Alex Walker <alex.walker@indicio.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reconcile conflicts, get reset hard, and implement desired changes in
controller/protocols.pySigned-off-by: Alex Walker ☀️ alex.walker@indicio.tech