Meteor repeats deviceready causing IndoorAtlas crash on Android #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the fix! I rebased your commit as f48340c and merged it |
|
You bet! Thanks for merging it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under some circumstances (maybe all circumstances?), Meteor will cause two deviceready events due to (I think) Meteor's hot code push causing a reset of cordova plugins. When this occurs, IA crashes in Android because onRequestPermissionResult sets mCbContext = null, so on Meteor's 2nd pass through the plugin init, execute() is not called, so mCbContext is null when onRequestPermissionResult tries to call mCbContext.sendPluginResult().
This fix removes the mCbContext = null to prevent this crash.
I just noticed the line number in the change below is 122, not like 97 as it should be in the 3.0 code because I made this change in the 2.x version of the plugin. This fix is to line 97 of the 3.0 code base.