Skip to content

Commit

Permalink
CRAN 0.0.7 resubmission
Browse files Browse the repository at this point in the history
  • Loading branch information
@IndrajeetPatil
IndrajeetPatil committed Dec 7, 2018
1 parent e5583f5 commit 39b6ed0
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 2 deletions.
4 changes: 2 additions & 2 deletions CRAN-RELEASE
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
This package was submitted to CRAN on 2018-12-06.
Once it is accepted, delete this file and tag the release (commit ebebfed668).
This package was submitted to CRAN on 2018-12-07.
Once it is accepted, delete this file and tag the release (commit e5583f5fb6).
1 change: 1 addition & 0 deletions tests/testthat/test_chisq_v_ci.R
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ context("chisq_v_ci")
testthat::test_that(
desc = "chisq_v_ci works",
code = {
testthat::skip_on_cran()

# using sampled 25% Titanic_full dataset
set.seed(123)
Expand Down
1 change: 1 addition & 0 deletions tests/testthat/test_cor_test_ci.R
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ context("cor_test_ci")
testthat::test_that(
desc = "cor_test_ci works",
code = {
testthat::skip_on_cran()

# using mtcars dataset
set.seed(123)
Expand Down
1 change: 1 addition & 0 deletions tests/testthat/test_kw_eta_h_ci.R
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ context("test_kw_eta_h_ci")
testthat::test_that(
desc = "Confidence interval for effect size for Kruskal-Wallis test ",
code = {
testthat::skip_on_cran()

# function output
set.seed(123)
Expand Down
1 change: 1 addition & 0 deletions tests/testthat/test_lm_effsize_ci.R
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ context("lm_effsize_ci")
testthat::test_that(
desc = "lm_effsize_ci works",
code = {
testthat::skip_on_cran()

# for reproducibility
set.seed(123)
Expand Down
2 changes: 2 additions & 0 deletions tests/testthat/test_t1way_ci.R
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ context("t1way_ci")
testthat::test_that(
desc = "t1way_ci works",
code = {
testthat::skip_on_cran()

# make a bogus dataframe to test against
# some plausible numbers, a negative value and an NA
bogusdata <- structure(list(
Expand Down
1 change: 1 addition & 0 deletions tests/testthat/test_yuend_ci_paired.R
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ context("test_yuend_ci_paired")
testthat::test_that(
desc = "Yuen's test on trimmed means for dependent samples works",
code = {
testthat::skip_on_cran()

# made up data
mydata <-
Expand Down

5 comments on commit 39b6ed0

@lintr-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R/ggcorrmat.R:367:9: warning: local variable ‘n_summary’ assigned but may not be used

​        n_summary <- numdf_summary(df = corr_df$n)
        ^~~~~~~~~

R/ggscatterstats.R:232:5: style: Opening curly braces should never go on their own line and should always be followed by a new line.

​    {
    ^

R/ggscatterstats.R:235:12: style: Commented code should be removed.

​        #  dplyr::filter(.data = ., !!rlang::enquo(label.expression))
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

R/helpers_ggbetween_anova_subtitles.R:389:1: style: Variable and function names should not be longer than 30 characters.

​subtitle_friedman_nonparametric <- function(data,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@lintr-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R/ggcorrmat.R:367:9: warning: local variable ‘n_summary’ assigned but may not be used

​        n_summary <- numdf_summary(df = corr_df$n)
        ^~~~~~~~~

R/ggscatterstats.R:232:5: style: Opening curly braces should never go on their own line and should always be followed by a new line.

​    {
    ^

R/ggscatterstats.R:235:12: style: Commented code should be removed.

​        #  dplyr::filter(.data = ., !!rlang::enquo(label.expression))
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

R/helpers_ggbetween_anova_subtitles.R:389:1: style: Variable and function names should not be longer than 30 characters.

​subtitle_friedman_nonparametric <- function(data,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@ibecav
Copy link
Contributor

@ibecav ibecav commented on 39b6ed0 Dec 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on getting it (re)submitted.

As you make plans for 0.0.8 please let me know I have a few ideas and issues that I'd like to contribute to.

@lintr-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R/ggcorrmat.R:367:9: warning: local variable ‘n_summary’ assigned but may not be used

​        n_summary <- numdf_summary(df = corr_df$n)
        ^~~~~~~~~

R/ggscatterstats.R:232:5: style: Opening curly braces should never go on their own line and should always be followed by a new line.

​    {
    ^

R/ggscatterstats.R:235:12: style: Commented code should be removed.

​        #  dplyr::filter(.data = ., !!rlang::enquo(label.expression))
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

R/helpers_ggbetween_anova_subtitles.R:389:1: style: Variable and function names should not be longer than 30 characters.

​subtitle_friedman_nonparametric <- function(data,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@lintr-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R/ggcorrmat.R:367:9: warning: local variable ‘n_summary’ assigned but may not be used

​        n_summary <- numdf_summary(df = corr_df$n)
        ^~~~~~~~~

R/ggscatterstats.R:232:5: style: Opening curly braces should never go on their own line and should always be followed by a new line.

​    {
    ^

R/ggscatterstats.R:235:12: style: Commented code should be removed.

​        #  dplyr::filter(.data = ., !!rlang::enquo(label.expression))
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

R/helpers_ggbetween_anova_subtitles.R:389:1: style: Variable and function names should not be longer than 30 characters.

​subtitle_friedman_nonparametric <- function(data,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Please sign in to comment.