Skip to content

Commit

Permalink
remove quantreg from suggests
Browse files Browse the repository at this point in the history
  • Loading branch information
IndrajeetPatil committed Mar 17, 2019
1 parent 1670dcb commit 972e711
Show file tree
Hide file tree
Showing 51 changed files with 39 additions and 94 deletions.
1 change: 0 additions & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ Suggests:
lme4,
MCMCglmm,
ordinal,
quantreg,
readr,
rmarkdown,
robust,
Expand Down
2 changes: 0 additions & 2 deletions R/helpers_ggbetween_anova_subtitles.R
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,6 @@ subtitle_anova_robust <- function(data,
k = 2,
...) {


# creating a dataframe
data <-
dplyr::select(
Expand Down Expand Up @@ -470,7 +469,6 @@ subtitle_anova_robust <- function(data,
k.parameter = k
)


# message about effect size measure
if (isTRUE(messages)) {
effsize_ci_message(nboot = nboot, conf.level = conf.level)
Expand Down
12 changes: 0 additions & 12 deletions codemeta.json
Original file line number Diff line number Diff line change
Expand Up @@ -166,18 +166,6 @@
},
"sameAs": "https://CRAN.R-project.org/package=ordinal"
},
{
"@type": "SoftwareApplication",
"identifier": "quantreg",
"name": "quantreg",
"provider": {
"@id": "https://cran.r-project.org",
"@type": "Organization",
"name": "Comprehensive R Archive Network (CRAN)",
"url": "https://cran.r-project.org"
},
"sameAs": "https://CRAN.R-project.org/package=quantreg"
},
{
"@type": "SoftwareApplication",
"identifier": "readr",
Expand Down
38 changes: 19 additions & 19 deletions docs/articles/web_only/ggcoefstats.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/articles/web_only/ggcoefstats_files/figure-html/glm2-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions docs/articles/web_only/ggstatsplot_paper.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions docs/articles/web_only/session_info.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions docs/index.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file modified docs/reference/figures/README-ggbarstats1-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/reference/figures/README-ggbarstats2-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/reference/figures/README-ggbetweenstats1-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/reference/figures/README-ggbetweenstats2-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/reference/figures/README-ggbetweenstats3-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/reference/figures/README-ggbetweenstats4-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/reference/figures/README-gghistostats1-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/reference/figures/README-gghistostats2-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/reference/figures/README-ggpiestats1-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/reference/figures/README-ggpiestats2-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/reference/figures/README-ggpiestats3-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/reference/figures/README-ggpiestats4-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/reference/figures/README-ggscatterstats1-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/reference/figures/README-ggscatterstats2-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/reference/figures/README-ggscatterstats3-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified man/figures/README-ggbarstats1-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified man/figures/README-ggbarstats2-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified man/figures/README-ggbetweenstats1-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified man/figures/README-ggbetweenstats2-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified man/figures/README-ggbetweenstats3-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified man/figures/README-ggbetweenstats4-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified man/figures/README-ggcoefstats1-1.png
Binary file modified man/figures/README-ggcoefstats2-1.png
Binary file modified man/figures/README-ggcorrmat1-1.png
Binary file modified man/figures/README-ggcorrmat3-1.png
Binary file modified man/figures/README-ggdotplotstats1-1.png
Binary file modified man/figures/README-ggdotplotstats2-1.png
Binary file modified man/figures/README-gghistostats1-1.png
Binary file modified man/figures/README-gghistostats2-1.png
Binary file modified man/figures/README-gghistostats4-1.png
Binary file modified man/figures/README-ggpiestats1-1.png
Binary file modified man/figures/README-ggpiestats2-1.png
Binary file modified man/figures/README-ggpiestats3-1.png
Binary file modified man/figures/README-ggpiestats4-1.png
Binary file modified man/figures/README-ggscatterstats1-1.png
Binary file modified man/figures/README-ggscatterstats2-1.png
Binary file modified man/figures/README-ggscatterstats3-1.png
Binary file modified man/figures/README-pirateplot-1.png
Binary file modified man/figures/README-theme_ggstatsplot-1.png
68 changes: 14 additions & 54 deletions tests/testthat/test_ggcoefstats.R
Original file line number Diff line number Diff line change
Expand Up @@ -634,54 +634,6 @@ testthat::test_that(
}
)

# check quantreg output ----------------------------------------------

testthat::test_that(
desc = "check quantreg output",
code = {
testthat::skip_on_cran()

# set up
set.seed(123)
library(quantreg)
data(stackloss)

# model
mod <-
quantreg::rq(
formula = stack.loss ~ stack.x,
data = stackloss,
method = "br"
)

# broom outputs
broom_df <-
broom::tidy(
x = mod,
se.type = "iid",
conf.int = TRUE,
conf.level = 0.90
)

# ggcoefstats outputs
tidy_df <- ggstatsplot::ggcoefstats(
x = mod,
se.type = "iid",
exclude.intercept = FALSE,
conf.level = 0.90,
output = "tidy"
)

# testing
testthat::expect_identical(broom_df$term, as.character(tidy_df$term))
testthat::expect_equal(broom_df$estimate, tidy_df$estimate, tolerance = 0.001)
testthat::expect_equal(broom_df$std.error, tidy_df$std.error, tolerance = 0.001)
testthat::expect_equal(broom_df$p.value, tidy_df$p.value, tolerance = 0.001)
testthat::expect_equal(broom_df$conf.low, tidy_df$conf.low, tolerance = 0.001)
testthat::expect_equal(broom_df$conf.high, tidy_df$conf.high, tolerance = 0.001)
}
)

# check gmm output ----------------------------------------------

testthat::test_that(
Expand Down Expand Up @@ -1373,12 +1325,20 @@ testthat::test_that(
cfit <- coxph(Surv(time, status) ~ age + sex, lung)
mod2 <- survfit(cfit)

# test failures
testthat::expect_error(
ggstatsplot::ggcoefstats(x = mod1)
)
testthat::expect_error(
ggstatsplot::ggcoefstats(x = mod2)
# mod-3
mod3 <- stats::aov(
formula = value ~ attribute * measure + Error(id / (attribute * measure)),
data = iris_long
)

# plot
p <- ggstatsplot::ggcoefstats(mod3)
pb <- ggplot2::ggplot_build(p)

# test failures
testthat::expect_error(ggstatsplot::ggcoefstats(x = mod1))
testthat::expect_error(ggstatsplot::ggcoefstats(x = mod2))
testthat::expect_null(pb$plot$labels$subtitle, NULL)

}
)

1 comment on commit 972e711

@lintr-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R/ggcorrmat.R:270:5: warning: local variable ‘corr.method.text’ assigned but may not be used

corr.method.text <- "Pearson"
    ^~~~~~~~~~~~~~~~

R/ggcorrmat.R:379:9: warning: local variable ‘n_summary’ assigned but may not be used

n_summary <- numdf_summary(corr_df$n)
        ^~~~~~~~~

R/ggscatterstats.R:215:5: style: Opening curly braces should never go on their own line and should always be followed by a new line.

​    {
    ^

R/helpers_ggbetween_anova_subtitles.R:282:1: style: Variable and function names should not be longer than 30 characters.

subtitle_friedman_nonparametric <- function(data,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

R/helpers_ggbetween_anova_subtitles.R:696:1: style: Variable and function names should not be longer than 30 characters.

subtitle_anova_parametric_repeated <- function(data,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

R/helpers_ggbetween_anova_subtitles.R:742:5: warning: local variable ‘effsize’ assigned but may not be used

effsize <- "omega"
    ^~~~~~~

R/helpers_ggbetween_anova_subtitles.R:794:10: style: Commented code should be removed.

#    effsize_ci_message(nboot = nboot, conf.level = conf.level)
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

R/helpers_ggbetween_t_subtitles.R:770:1: style: Lines should not be more than 100 characters.

#' (\url{https://www.uvm.edu/~dhowell/methods7/Supplements/Confidence\%20Intervals\%20on\%20Effect\%20Size.pdf}).
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

R/helpers_gghistostats.R:49:5: warning: local variable ‘label.value’ assigned but may not be used

label.value <- x_pos
    ^~~~~~~~~~~

tests/testthat/test_ggbetweenstats.R:178:7: style: Commented code should be removed.

# testthat::expect_identical(p$labels$subtitle, p_subtitle)
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Please sign in to comment.