-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup build workflow #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 👍 🥳
None of the comments are a must change now :) But improvements and discussions for next iterations and refinements.
- name: Checkout repository | ||
uses: actions/checkout@v2 | ||
|
||
- name: Setup environment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checkout action has some options like recursive cloning etc.
Maybe some of them can be directly handled by the action.
|
||
- name: copy/link repository to arduino path | ||
run: | | ||
mkdir ~/.arduino15/packages/infineon/hardware/psoc/0.1.0-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should extend the setup script to also do these things?
In general, whatever we can encapsulate in a script(s) is recommendable.
We can keep the workflows to matrix management and flow control of the ci/cd. And in case we need to migrate to other ci/cd it would be easier.
if: startsWith(github.ref, 'refs/tags/V') | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/setup-python@v4 | ||
- name: Checkout actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is secondary, but we should restrict more the release triggers. Only tags and or publish?
Generally the release will come from the "main", and all the ci/cd should be green.
Eventually some interim dev release would come from other branches, like right now. Maybe also handle those exceptions
.github/workflows/compile.yml
Outdated
# Compile the sample code for the selected board and board support package with the arduino compiler | ||
- name: Compile Sketch | ||
run: | | ||
export CY_TOOLS_PATHS=~/.arduino15/packages/infineon/tools/ModusToolbox/tools_3.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This export path either should be done directly in some platform.txt recipe... or directly in the MTB makefile. Which I think we can overwrite, by passing it as flag to the makefile.
|
||
def get_latest_package_index_json(): | ||
return requests.get( | ||
"https://github.com/Infineon/arduino-core-psoc/releases/download/0.0.0-none/package_psoc_index.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should point to latest URL, and ideally for development purposes we can make it a parameter somehow.
platform.txt
Outdated
@@ -5,8 +5,8 @@ | |||
|
|||
# The information about this Arduino compatible environment | |||
# --------- | |||
name=PSoC Family | |||
version=0.0.1 | |||
name=PSOC Family |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We´ll rename this to what we agree regarding the conventions.
3520a46
to
518b5ba
Compare
Signed-off-by: Ramya Subramanyam <ramya.subramanyam@infineon.com>
Signed-off-by: Ramya Subramanyam <ramya.subramanyam@infineon.com>
Signed-off-by: Ramya Subramanyam <ramya.subramanyam@infineon.com>
Signed-off-by: Ramya Subramanyam <ramya.subramanyam@infineon.com>
Signed-off-by: Ramya Subramanyam <ramya.subramanyam@infineon.com>
Signed-off-by: Ramya Subramanyam <ramya.subramanyam@infineon.com>
Signed-off-by: Ramya Subramanyam <ramya.subramanyam@infineon.com>
…dev setup script. Signed-off-by: Ramya Subramanyam <ramya.subramanyam@infineon.com>
2884e3d
to
5aa6877
Compare
Signed-off-by: Ramya Subramanyam <ramya.subramanyam@infineon.com>
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
now we have Arduino cli build is running on the lab PC with linux environment automatically on every commit/PR.