Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload script refactor #15

Merged
merged 9 commits into from
Oct 3, 2024
Merged

Upload script refactor #15

merged 9 commits into from
Oct 3, 2024

Conversation

jaenrig-ifx
Copy link
Member

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

This PR addresses the following topics:

  • Path slashes issues in windows environment solved by .bat file and modifications in get_build_flags.py script (this one is anyhow to be refactor to avoid python dependency).
  • Cleanup, simplified and more modular platform.txt for upload recipe.
  • Bash script with the following features:
    • Verbose mode: prints all arguments, command line openocd call and openocd output
    • Quiet (default) mode: openocd output saved in a log file in build folder.
    • help document all positional and optional arguments.
    • Error parser helper to parse openocd errors into user friendly messages (coloured in red).

@jaenrig-ifx
platform.txt: Refactor to reuse tools/upload.sh script.
bf8155d 
Signed-off-by: jaenrig-ifx <enriquezgarcia.external@infineon.com>
@jaenrig-ifx
tools/upload.sh: Added upload.sh support script.
c0c627e 
Signed-off-by: jaenrig-ifx <enriquezgarcia.external@infineon.com>
@jaenrig-ifx
tools/mtb_build_info.py: Replace double back slashed in windows.
ec6aed0 
Signed-off-by: jaenrig-ifx <enriquezgarcia.external@infineon.com>
@jaenrig-ifx
tools/upload.sh: Replaced openocd_path by mtb_tools_path.
6152799 
Signed-off-by: jaenrig-ifx <enriquezgarcia.external@infineon.com>
@jaenrig-ifx
tools/upload.bat: Added adapter .bat script for Windows.
3628952 
Signed-off-by: jaenrig-ifx <enriquezgarcia.external@infineon.com>
@jaenrig-ifx
platform.txt: Added windows pattern and modified linux pattern.
72e2994 
Signed-off-by: jaenrig-ifx <enriquezgarcia.external@infineon.com>
@jaenrig-ifx
platform.txt: Renamed args as per boards.txt refactor.
dcfe844 
Signed-off-by: jaenrig-ifx <enriquezgarcia.external@infineon.com>
@jaenrig-ifx
tools/upload.bat: Removed old comment.
d2e45fd 
Signed-off-by: jaenrig-ifx <enriquezgarcia.external@infineon.com>
@jaenrig-ifx
tools/upload.sh: Openocd extension not required in mtb-shell env.
a08fd9f 
Signed-off-by: jaenrig-ifx <enriquezgarcia.external@infineon.com>
ramya-subramanyam
ramya-subramanyam approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@ramya-subramanyam ramya-subramanyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good!

@ramya-subramanyam ramya-subramanyam merged commit b61214d into develop Oct 3, 2024
3 checks passed
@ramya-subramanyam ramya-subramanyam deleted the upload-script-refactor branch October 3, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramya-subramanyam ramya-subramanyam ramya-subramanyam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaenrig-ifx @ramya-subramanyam